wassname/optuna-dashboard
1
0
Fork 0
mirror of https://github.com/wassname/optuna-dashboard.git synced 2026-09-10 12:23:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Organize TODOs

Browse Source
This commit is contained in:
porink0424
2024-08-07 15:43:10 +09:00
parent cdd528294b
commit 159b6bfa93
2 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jupyterlab/src/apiClient.ts
+15 -11
View File
@@ -64,8 +64,8 @@ export class JupyterlabAPIClient extends APIClient {
preference_history: res.preference_history?.map(
this.convertPreferenceHistory
),
plotly_graph_objects: res.plotly_graph_objects, // TODO: Support this
artifacts: res.artifacts, // TODO: Support this
plotly_graph_objects: res.plotly_graph_objects,
artifacts: res.artifacts,
skipped_trial_numbers: res.skipped_trial_numbers ?? [],
}
})
@@ -127,7 +127,7 @@ export class JupyterlabAPIClient extends APIClient {
study_name: res.study_name,
directions: res.directions,
user_attrs: res.user_attrs,
is_preferential: res.is_prefential, // TODO: Fix typo
is_preferential: res.is_prefential,
datetime_start: res.datetime_start
? new Date(res.datetime_start)
: undefined,
@@ -161,7 +161,7 @@ export class JupyterlabAPIClient extends APIClient {
dataUrl: string
): Promise<UploadArtifactAPIResponse> =>
requestAPI<UploadArtifactAPIResponse>(
`/api/artifacts/${studyId}/${trialId}`, // TODO: Make API
`/api/artifacts/${studyId}/${trialId}`,
{
body: JSON.stringify({
file: dataUrl,
@@ -178,7 +178,7 @@ export class JupyterlabAPIClient extends APIClient {
dataUrl: string
): Promise<UploadArtifactAPIResponse> =>
requestAPI<UploadArtifactAPIResponse>(
`/api/artifacts/${studyId}`, // TODO: Make API
`/api/artifacts/${studyId}`,
{
body: JSON.stringify({
file: dataUrl,
@@ -195,7 +195,7 @@ export class JupyterlabAPIClient extends APIClient {
artifactId: string
): Promise<void> =>
requestAPI<void>(
`/api/artifacts/${studyId}/${trialId}/${artifactId}`, // TODO: Make API
`/api/artifacts/${studyId}/${trialId}/${artifactId}`,
{
method: "DELETE",
}
@@ -204,7 +204,7 @@ export class JupyterlabAPIClient extends APIClient {
})
deleteStudyArtifact = (studyId: number, artifactId: string): Promise<void> =>
requestAPI<void>(
`/api/artifacts/${studyId}/${artifactId}`, // TODO: Make API
`/api/artifacts/${studyId}/${artifactId}`,
{
method: "DELETE",
}
@@ -293,13 +293,17 @@ export class JupyterlabAPIClient extends APIClient {
}).then(() => {
return
})
getPlot = (studyId: number, plotType: PlotType): Promise<PlotResponse> => {
throw new Error("Method not implemented.") // TODO: Implement
}
getPlot = (studyId: number, plotType: PlotType): Promise<PlotResponse> =>
requestAPI<PlotResponse>(`/api/studies/${studyId}/plot/${plotType}`)
.then<PlotResponse>((res) => (res))
getCompareStudiesPlot = (
studyIds: number[],
plotType: CompareStudiesPlotType
): Promise<PlotResponse> => {
throw new Error("Method not implemented.") // TODO: Implement
return requestAPI<PlotResponse>(
`/api/compare-studies/plot/${plotType}`, {
body: JSON.stringify({ study_ids: studyIds }),
}
).then<PlotResponse>((res) => (res))
}
}
optuna_dashboard/ts/apiClient.ts
+1 -1
View File
@@ -103,7 +103,7 @@ export type RenameStudyResponse = {
study_name: string
directions: Optuna.StudyDirection[]
user_attrs: Optuna.Attribute[]
is_prefential: boolean // TODO: Fix typo
is_prefential: boolean // TODO(porink0424): Fix typo
datetime_start?: string
}