areshytko and Alexander Reshytko
9754c5da55
load_spawn_weights only in proc rank 0 ( #1385 )
...
Co-authored-by: Alexander Reshytko <areshytko@Alexanders-MacBook-Pro.local >
2020-04-06 10:17:16 -04:00
4ed3027309
Set precision=16 when use_amp is passed as True ( #1145 )
...
* Set precision=16 when use_amp is passed as True
* Update CHANGELOG.md
* add use_amp to deprecated API
* Update trainer.py
* Update trainer.py
* move the use_amp attribute to deprecated API
* move use_amp deprecation back to Trainer's __init__
* drop unsed
* drop deprecated
* reorder imports
* typing
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
Co-authored-by: William Falcon <waf2107@columbia.edu >
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
2020-04-06 08:13:24 -04:00
Adrian Wälchli
26cb5f6817
Improved docs for LightningModule ( #1389 )
...
* improve docs for LightingModule
* fix typos
* revert a doctest
* more fixes
2020-04-06 08:12:44 -04:00
5f6be4dd53
Pin sphinx version (fix for current docs build errors) ( #1382 )
...
* Update requirements.txt
* Update docs/requirements.txt
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* freeze sphinx version
* Update docs/source/conf.py
Co-Authored-By: Adrian Wälchli <aedu.waelchli@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
2020-04-06 06:42:33 +00:00
Jeremy Jordan
91c9b29d47
add trainer attribute to denote if interrupted ( #1368 )
...
* add trainer attribute to denote if interrupted
* bugfix and formatting
2020-04-05 11:12:41 -04:00
Adrian Wälchli
b358714a9a
Adding Intersphinx documentation links ( #1369 )
...
* added intersphinx links for base packages
* remove comment
2020-04-05 11:11:58 -04:00
Jeremy Jordan
38c56081ac
fix docs on saving checkpoints manually ( #1373 )
2020-04-05 11:10:44 -04:00
Ethan Harris and Jirka Borovec
b18accc64c
Add warning for few workers ( #1378 )
...
* Add warning for few workers
* Fix style issue
* Update CHANGELOG.md
* Update test
* formatting
* formatting
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-05 11:07:16 -04:00
Jirka Borovec
fdcf9cd518
add forgotten change logs ( #1380 )
...
* forgot change logs
* more missing
* more missing
2020-04-05 11:05:13 -04:00
f1e11d8b38
model_checkpoint to save all models ( #1359 )
...
* model_checkpoint to save all models
* changelog
* rise if
Co-authored-by: jamesjjcondon <jamesjjcondon@gmail.com >
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
2020-04-05 15:56:26 +02:00
Adrian Wälchli and Jirka Borovec
1f2da71069
Improved docs for callbacks ( #1370 )
...
* improved docs for callbacks
* class references
* make doctest pass
* doctests
* fix lines too long
* fix line too long
* fix permission error in doctest
* Apply suggestions from code review
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* fix doctest
* fix default
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-05 09:38:52 +00:00
Jirka Borovec
22bedf9b57
simplify examples structure ( #1247 )
...
* simplify examples structure
* update changelog
* fix imports
* rename example
* rename scripts
* changelog
2020-04-03 17:57:34 -04:00
William Falcon and Shubham Agarwal
16f4cc9ff0
Shubhamagarwal92 master ( #1349 )
...
* SA: for #958 : set torch cuda device when finding root
* SA: for #958 : removing root gpu hack in trainer/evaluation_loop
* SA: setting torch cuda device
* comment line too long
* check if root gpu exists or available
* Incorporating suggestions on #1094
* since root gpu returns none instead of -1 for cpu
* undo changes
* fixed dp memory thing
Co-authored-by: Shubham Agarwal <shubhamagarwal92@gmail.com >
2020-04-03 17:56:19 -04:00
Justus Schock and J. Borovec
f6a86e8551
generalize reinstantiation of dataloader ( #1346 )
...
* generalize reinstantiation of dataloader
* fix condition
* add test
* update changelog
* fix changelog
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
2020-04-03 17:55:08 -04:00
William Falcon and Jirka Borovec
e68ba1c836
added warnings to unimplemented methods ( #1317 )
...
* added warnings and removed default optimizer
* opt
* Apply suggestions from code review
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-03 15:06:51 -04:00
3c5530c29d
Wandb bug/wandb multi ( #1360 )
...
* Allow reinits in sub procs
* Dont create an experiment on pickle, name, or project
* Comments consistency
* Fix test
* Apply suggestions from code review
Co-authored-by: Chris Van Pelt <vanpelt@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-03 15:03:00 -04:00
dd5a05926c
Borisdayma: fix(wandb) - fix watch method ( #1361 )
...
* fix(wandb): fix watch method
* rebased
* Apply suggestions from code review
Co-authored-by: Boris Dayma <boris.dayma@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-03 15:02:38 -04:00
Jean-Baptiste SCHIRATTI
e570d2e1ca
Doc fixes ( #1362 )
...
* Doc fixes from #1357 (awaelchli's comments) + changelog.
* Fix indentation.
* Add blank line to fix doc build?
2020-04-03 15:02:20 -04:00
Adrian Wälchli
bf990a3cb3
Example docs formatting ( #1364 )
...
* update basic examples
* update domain examples
* reinforse -> reinforce
* update full examples
* update multi node examples
* update examples readme
* fix copy paste
* fix line too long
2020-04-03 15:01:40 -04:00
Tullie Murrell
38e89dd890
Fix fast_dev_run running validation twice ( #1365 )
2020-04-03 15:00:26 -04:00
Tullie Murrell
b31edf37bf
Change min max gpu memory to be on their own plots ( #1358 )
2020-04-03 14:59:27 -04:00
William Falcon
003ca510fa
Update README.md
2020-04-03 10:10:16 -04:00
William Falcon
42d9a02c08
Update README.md
2020-04-03 10:04:54 -04:00
Santiago Castro
f9bb796d29
Add highlighting to the BibTeX entry in README ( #1356 )
2020-04-03 09:52:41 -04:00
Pariente Manuel and William Falcon
c51651dba8
Add parity test for simple RNN ( #1351 )
...
* Add parity test for simple RNN
* Update test_rnn_parity.py
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-04-03 09:43:14 -04:00
Adrian Wälchli
ebd9fc9530
Fix for incorrect run on the validation set with overwritten validation_epoch_end and test_end ( #1353 )
...
* reorder if clauses
* fix wrong method overload in test
* fix formatting
* update change_log
* fix line too long
2020-04-03 09:25:32 -04:00
Jean-Baptiste SCHIRATTI and Jean-Baptiste SCHIRATTI
868b172f05
Make training_epoch_end behave like validation_epoch_end ( #1357 )
...
* Make training_epoch_end behave like validation_epoch_end + minor fixes in docstrings.
* Minor fixes (Borda's comments).
* Detach tensors in batch_output (to avoid possible memory leak) + doc fix.
Co-authored-by: Jean-Baptiste SCHIRATTI <jean-baptisteschiratti@MacBook-Pro-de-Jean-Baptiste.local >
2020-04-03 14:43:26 +02:00
William Falcon
2eca8a9ef2
quick patch __code__ ( #1352 )
...
* quick patch
* testing fix
* testing fix
* testing fix
* testing fix
* testing fix
* testing fix
* testing fix
* testing fix
* testing fix
* testing fix
* testing fix
* testing fix
* testing fix
2020-04-03 08:40:02 -04:00
Santiago Castro
1576ad9963
Fix docs typo ( #1355 )
...
* Fix typo
* Fix typo
2020-04-03 07:35:09 +02:00
f33b5a8d99
Simplify progress bar args ( #1108 )
...
* show progress bar dependent on refresh_rate
* test progress_bar_refresh control show bar
* remove show_progress_bar from other tests
* borda fixes
* flake8 fix
* changelog update prog bar refresh rate
* move show_progress_bar to deprecated 0.9 api
* rm show_progress_bar references, test deprecated
* Update pytorch_lightning/trainer/__init__.py
* fix test
* changelog
* minor CHANGELOG.md format
* Update pytorch_lightning/trainer/__init__.py
* Update pytorch_lightning/trainer/trainer.py
Co-authored-by: Gerard Bentley <gbkh2015@mymail.pomona.edu >
Co-authored-by: William Falcon <waf2107@columbia.edu >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
2020-04-03 00:53:00 +02:00
Jirka Borovec
724b787cd1
faster CI testing ( #1323 )
...
* MNIST digits
* increase test acc
* smaller parity
* drone builds
* increase GH action timeout
* drone format
* fix paths
* drone cache
* circle cache
* fix test
* lower nb epochs
* circleCI
* user orb
* fix test
* fix test
* circle cache
* circle cache
* circle cache
* comment caches
* benchmark batch size
* cache dataset
* smaller dataset
* smaller dataset
* fix nb samples
* batch size
* fix test
2020-04-02 12:28:44 -04:00
Jirka Borovec and William Falcon
e73dcb8cbe
add python 3.8 testing ( #915 )
...
* add python 3.8 test
* update info
* py38 >> torch 1.2
* skip py38 minimal
* changelog
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-04-02 12:20:45 -04:00
2912239fe6
Add useful errors when model is not configured correctly ( #1199 )
...
* add check_model_configuration method
* trying to fix errors
* trying to fix tests
* added test_epoch_end to lightning template
* fix tests
* fix new test after rebase
* fix spelling
* added more checks
* updated formating
* added tests
* fixed CHANGELOG
* Apply suggestions from code review
* move test to new module
* change check on configure_optimizers
Co-authored-by: Nicki Skafte <nugginea@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-02 11:53:37 -04:00
Ethan Harris
ddb59130f8
Fix iterable dataset docs ( #1342 )
2020-04-02 11:51:43 -04:00
Ethan Harris and Jirka Borovec
28242f02d1
Remove default optimizer, add None optimizer option ( #1279 )
...
* Add warning when using default optimizer
* Refactor optimizer tests to test_optimizers
* Remove default optimizer, add option to use no optimizer
* Update CHANGELOG.md
* Update pytorch_lightning/trainer/optimizers.py
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* Fix style
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-02 11:48:53 -04:00
Justus Schock and Jirka Borovec
80dc9795bd
Automatic PyPi Release ( #1324 )
...
* Add Workflow for Automated pypi releases
* Rename pypi_release to pypi_release.yml
* Update .github/workflows/pypi_release.yml
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* Update .github/workflows/pypi_release.yml
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* Add releases to test.pypi
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-02 11:47:37 -04:00
William Falcon and Adrian Wälchli
3cb149f4f4
Removes need to unsqueeze from dp ( #1319 )
...
* removes need to unsqueeze from dp
* removes need to unsqueeze from dp
* fixed examples
* added auto unsqueeze
* added auto unsqueeze
* added auto unsqueeze
* added auto unsqueeze
* Update pytorch_lightning/overrides/data_parallel.py
Co-Authored-By: Adrian Wälchli <adrian.waelchli@students.unibe.ch >
* fixed dp parse
* fixed dp parse
Co-authored-by: Adrian Wälchli <adrian.waelchli@students.unibe.ch >
2020-04-02 11:46:20 -04:00
Boris Dayma
6b41b5c589
feat(wandb): save models on wandb ( #1339 )
...
* feat(wandb): save models on wandb
* docs(changelog): allow to upload models on W&B
2020-04-02 08:55:34 -04:00
04935ea718
fixed extra dataloader bug ( #1196 )
...
* fixed extra dataloader bug
* Update pytorch_lightning/trainer/training_loop.py
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* updated CHANGELOG
* Small non-repetition change
self.get_model() => model as it was already defined
* Update CHANGELOG.md
* changed argument name to reload_train_dataloader_every_epoch
* fixed doc underline too short
* reverted to `reload_dataloaders_every_epoch`
* fixed val and test reloading
* fixed val and test reloading
Co-authored-by: TevenLeScao <teven.lescao@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-02 11:41:56 +02:00
William Falcon
e48422df38
Sampler ( #1328 )
...
* sampler
* check for dataloader type
* check for dataloader type
* fixed sampler cases
2020-04-01 12:57:36 -04:00
William Falcon
7de51f78ac
Sampler ( #1318 )
...
* sampler
* sampler
* sampler
* check for dataloader type
* check for dataloader type
2020-03-31 18:22:45 -04:00
Asaf Manor and Jirka Borovec
aca8c7e6f3
Optimizer Frequencies logic, and new configure_optimizers ( #1269 )
...
* init_optimizers accepts Dict, Sequence[Dict]
and returns optimizer_frequencies.
optimizer_frequencies was added as a member of Trainer.
* Optimizer frequencies logic implemented in training_loop.
Description added to configure_optimizers in LightningModule
* optimizer frequencies tests added to test_gpu
* Fixed formatting for merging PR #1269
* Apply suggestions from code review
* Apply suggestions from code review
Co-Authored-By: Asaf Manor <32155911+asafmanor@users.noreply.github.com >
* Update trainer.py
* Moving get_optimizers_iterable() outside.
* Update note
* Apply suggestions from code review
* formatting
* formatting
* Update CHANGELOG.md
* formatting
* Update CHANGELOG.md
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-03-31 16:41:24 +00:00
Jirka Borovec
ee68d5ba8e
reorder deprecated args ( #1230 )
2020-03-31 09:01:47 -04:00
Adrian Wälchli
d6646e151a
Move some tests to correct subfolder/file ( #1312 )
...
* move some tests to trainer file
* fix imports
2020-03-31 08:58:46 -04:00
Jirka Borovec
6ddb03922a
Profiler summary ( #1259 )
...
* refactor and add types
* add Prorfiler summary
* fix imports
* Revert "refactor and add types"
This reverts commit b4c552fa
* changelog
* revert rename
* fix test
* mute verbose
2020-03-31 08:57:48 -04:00
Adrian Wälchli and mergify[bot]
4dcb9d3e30
fixed type hint for weights_summary arg ( #1313 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-03-31 13:42:29 +02:00
Adrian Wälchli
1aba411da9
Early stopping when validation is disabled ( #1235 )
...
* early stop fallback to train epoch
* added test
* fix imports
* update docs
* update changelog
* fix typo
2020-03-31 06:24:26 +00:00
a707d4bea1
Replace Wandb callback's finalize with no-op ( #1193 )
...
* Replace Wandb callback's finalize with no-op
* Update pytorch_lightning/loggers/wandb.py
* Update wandb.py
* remove wandb logger's finalize and update tests
* update changelog
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-03-30 18:45:06 -04:00
2ccc7456ca
Error on zero length dataloaders ( #1280 )
...
* error_on_zero_length
* update CHANGELOG.md
* added test
* Update pytorch_lightning/trainer/data_loading.py
Co-authored-by: Nicki Skafte <nugginea@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-03-30 18:43:53 -04:00
09167efdb5
Checkpointing interval ( #1272 )
...
* formatting
* formatting
* fix interval
* fix train loop
* fix test
* parametrize test
* Apply suggestions from code review
Co-Authored-By: Adrian Wälchli <adrian.waelchli@students.unibe.ch >
* fix calling
* flake8
* add types
Co-authored-by: Adrian Wälchli <adrian.waelchli@students.unibe.ch >
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-03-30 18:37:02 -04:00