Jirka Borovec and William Falcon
e73dcb8cbe
add python 3.8 testing ( #915 )
...
* add python 3.8 test
* update info
* py38 >> torch 1.2
* skip py38 minimal
* changelog
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-04-02 12:20:45 -04:00
2912239fe6
Add useful errors when model is not configured correctly ( #1199 )
...
* add check_model_configuration method
* trying to fix errors
* trying to fix tests
* added test_epoch_end to lightning template
* fix tests
* fix new test after rebase
* fix spelling
* added more checks
* updated formating
* added tests
* fixed CHANGELOG
* Apply suggestions from code review
* move test to new module
* change check on configure_optimizers
Co-authored-by: Nicki Skafte <nugginea@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-02 11:53:37 -04:00
Ethan Harris
ddb59130f8
Fix iterable dataset docs ( #1342 )
2020-04-02 11:51:43 -04:00
Ethan Harris and Jirka Borovec
28242f02d1
Remove default optimizer, add None optimizer option ( #1279 )
...
* Add warning when using default optimizer
* Refactor optimizer tests to test_optimizers
* Remove default optimizer, add option to use no optimizer
* Update CHANGELOG.md
* Update pytorch_lightning/trainer/optimizers.py
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* Fix style
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-02 11:48:53 -04:00
Justus Schock and Jirka Borovec
80dc9795bd
Automatic PyPi Release ( #1324 )
...
* Add Workflow for Automated pypi releases
* Rename pypi_release to pypi_release.yml
* Update .github/workflows/pypi_release.yml
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* Update .github/workflows/pypi_release.yml
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* Add releases to test.pypi
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-02 11:47:37 -04:00
William Falcon and Adrian Wälchli
3cb149f4f4
Removes need to unsqueeze from dp ( #1319 )
...
* removes need to unsqueeze from dp
* removes need to unsqueeze from dp
* fixed examples
* added auto unsqueeze
* added auto unsqueeze
* added auto unsqueeze
* added auto unsqueeze
* Update pytorch_lightning/overrides/data_parallel.py
Co-Authored-By: Adrian Wälchli <adrian.waelchli@students.unibe.ch >
* fixed dp parse
* fixed dp parse
Co-authored-by: Adrian Wälchli <adrian.waelchli@students.unibe.ch >
2020-04-02 11:46:20 -04:00
Boris Dayma
6b41b5c589
feat(wandb): save models on wandb ( #1339 )
...
* feat(wandb): save models on wandb
* docs(changelog): allow to upload models on W&B
2020-04-02 08:55:34 -04:00
04935ea718
fixed extra dataloader bug ( #1196 )
...
* fixed extra dataloader bug
* Update pytorch_lightning/trainer/training_loop.py
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* updated CHANGELOG
* Small non-repetition change
self.get_model() => model as it was already defined
* Update CHANGELOG.md
* changed argument name to reload_train_dataloader_every_epoch
* fixed doc underline too short
* reverted to `reload_dataloaders_every_epoch`
* fixed val and test reloading
* fixed val and test reloading
Co-authored-by: TevenLeScao <teven.lescao@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-04-02 11:41:56 +02:00
William Falcon
e48422df38
Sampler ( #1328 )
...
* sampler
* check for dataloader type
* check for dataloader type
* fixed sampler cases
2020-04-01 12:57:36 -04:00
William Falcon
7de51f78ac
Sampler ( #1318 )
...
* sampler
* sampler
* sampler
* check for dataloader type
* check for dataloader type
2020-03-31 18:22:45 -04:00
Asaf Manor and Jirka Borovec
aca8c7e6f3
Optimizer Frequencies logic, and new configure_optimizers ( #1269 )
...
* init_optimizers accepts Dict, Sequence[Dict]
and returns optimizer_frequencies.
optimizer_frequencies was added as a member of Trainer.
* Optimizer frequencies logic implemented in training_loop.
Description added to configure_optimizers in LightningModule
* optimizer frequencies tests added to test_gpu
* Fixed formatting for merging PR #1269
* Apply suggestions from code review
* Apply suggestions from code review
Co-Authored-By: Asaf Manor <32155911+asafmanor@users.noreply.github.com >
* Update trainer.py
* Moving get_optimizers_iterable() outside.
* Update note
* Apply suggestions from code review
* formatting
* formatting
* Update CHANGELOG.md
* formatting
* Update CHANGELOG.md
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-03-31 16:41:24 +00:00
Jirka Borovec
ee68d5ba8e
reorder deprecated args ( #1230 )
2020-03-31 09:01:47 -04:00
Adrian Wälchli
d6646e151a
Move some tests to correct subfolder/file ( #1312 )
...
* move some tests to trainer file
* fix imports
2020-03-31 08:58:46 -04:00
Jirka Borovec
6ddb03922a
Profiler summary ( #1259 )
...
* refactor and add types
* add Prorfiler summary
* fix imports
* Revert "refactor and add types"
This reverts commit b4c552fa
* changelog
* revert rename
* fix test
* mute verbose
2020-03-31 08:57:48 -04:00
Adrian Wälchli and mergify[bot]
4dcb9d3e30
fixed type hint for weights_summary arg ( #1313 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-03-31 13:42:29 +02:00
Adrian Wälchli
1aba411da9
Early stopping when validation is disabled ( #1235 )
...
* early stop fallback to train epoch
* added test
* fix imports
* update docs
* update changelog
* fix typo
2020-03-31 06:24:26 +00:00
a707d4bea1
Replace Wandb callback's finalize with no-op ( #1193 )
...
* Replace Wandb callback's finalize with no-op
* Update pytorch_lightning/loggers/wandb.py
* Update wandb.py
* remove wandb logger's finalize and update tests
* update changelog
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-03-30 18:45:06 -04:00
2ccc7456ca
Error on zero length dataloaders ( #1280 )
...
* error_on_zero_length
* update CHANGELOG.md
* added test
* Update pytorch_lightning/trainer/data_loading.py
Co-authored-by: Nicki Skafte <nugginea@gmail.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-03-30 18:43:53 -04:00
09167efdb5
Checkpointing interval ( #1272 )
...
* formatting
* formatting
* fix interval
* fix train loop
* fix test
* parametrize test
* Apply suggestions from code review
Co-Authored-By: Adrian Wälchli <adrian.waelchli@students.unibe.ch >
* fix calling
* flake8
* add types
Co-authored-by: Adrian Wälchli <adrian.waelchli@students.unibe.ch >
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-03-30 18:37:02 -04:00
Jirka Borovec
3476d2f279
auto add reviewrs via Mergify ( #1257 )
...
* update mergify nb checks
* lover merge action
* draft auto review
* fix rule
2020-03-30 18:32:52 -04:00
Jirka Borovec
2ca5356429
clear skipping tests ( #1285 )
...
* clear skipping tests
* fix simple/multi GPU
* review: simplify
2020-03-30 18:29:23 -04:00
William Falcon
31a658e558
made load from checkpoint flexible ( #1307 )
...
* made load from checkpoint flexible
* made load from checkpoint flexible
* made load from checkpoint flexible
2020-03-30 18:28:51 -04:00
Jirka Borovec and William Falcon
31017120fd
fix incomplete RunningMean ( #1309 )
...
* fix RunningMean
* changelog
* fix none
* Update supporters.py
just needed to multiply by zero for init
* Revert "Update supporters.py"
This reverts commit 7e0da6c6
* fix NaN
* formatting
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-03-30 18:28:31 -04:00
Adrian Wälchli and Jirka Borovec
b7de42f70d
Add MNIST dataset & drop torchvision dep. from tests ( #986 )
...
* added custom mnist without torchvision dep
* move files so it does not conflict with mnist gitignore
* mock torchvision for tests
* fix line too long
* fix line too long
* fix "module level import not at top of file" warning
* move mock imports to __init__.py
* simplify MNIST a lot and download directly the .pt files
* further simplify and clean up mnist
* revert import overrides
* make as before
* drop PIL requirement
* move mnist.py to datasets subfolder
* use logging instead of print
* choose same name as in torchvision
* remove torchvision and pillow also from yml file
* refactor if train
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* capitalized class attr
* moved mnist to models
* re-added datsets ignore
* better name for file variable
* Update mnist.py
* move dataset classes to datasets.py
* new line
* update
* update
* fix automerge
* move to base folder
* adapt testingmnist to new mnist base class
* remove temporal fix
* fix datatype
* remove old testingmnist
* readable
* fix import
* fix whitespace
* docstring
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* Update tests/base/datasets.py
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* changelog
* added types
* Update CHANGELOG.md
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* exist->isfile
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* index -> idx
* temporary fix for trains error
* better changelog message
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-03-30 18:25:37 -04:00
William Falcon and J. Borovec
18d055a390
Parity test ( #1284 )
...
* adding test
* adding test
* added base parity model
* added base parity model
* added parity test
* added parity test
* added parity test
* added parity test
* added parity test
* added parity test
* added parity test
* added parity test
* added parity test
* added parity test
* added parity test
* added parity test
* added parity test
* added parity test
* added parity test
* move parity to benchmark
* formatting
* fixed gradient acc sched
* move parity to benchmark
* formatting
* fixed gradient acc sched
* skip for CPU
* call last
Co-authored-by: J. Borovec <jirka.borovec@seznam.cz >
2020-03-30 18:16:32 -04:00
Jirka Borovec
c869dd8b8f
make evaluate private ( #1260 )
...
* make evaluate private
* changelog
2020-03-30 12:14:27 -04:00
sneiman and seth
6dfe9951e1
validation and training loops run the partial dataset ( #1192 )
...
* auto_add_sampler() fix
* auto_add_sampler() fix
Co-authored-by: seth <seth@duckpapa.com >
2020-03-30 12:13:34 -04:00
davinnovation
1d1aba812b
update readme typo ( #1292 )
2020-03-30 10:12:48 -04:00
William Falcon
31b71483c4
remove .item which causes sync issues ( #1254 )
...
* remove .item which causes sync issues
* fixed gradient acc sched
* fixed gradient acc sched
2020-03-29 20:20:34 -04:00
Paweł Rzepiński
b74a3c5106
Fix training resuming docs ( #1265 )
2020-03-29 15:29:48 -04:00
Donal Byrne and Donal Byrne
fb42872259
Update docs iterable datasets ( #1281 )
...
* Updated Sequencial Data docs
* Sequntial Data section now contains info on using IterableDatasets
* * Undid reformatting of bullet points
* * added information about val_check_interval
Co-authored-by: Donal Byrne <Donal.Byrne@xperi.com >
2020-03-29 15:29:09 -04:00
Ethan Harris
ab09faa15e
Add support for iterable datasets when val_check_interval=1.0 ( #1283 )
...
* Add support for iterable datasets when val_check_interval=1.0
* Update CHANGELOG.md
2020-03-29 15:27:44 -04:00
Jeremy Jordan
54507f417e
fix logging config and add profiler test ( #1267 )
2020-03-29 14:56:36 -04:00
dab3b965cb
Example: Simple RL example using DQN/Lightning ( #1232 )
...
* Example: Simple RL example using DQN/Lightning
* DQN RL Agent using Lightning
* Uses Iterable Dataset for Replay Buffer
* Buffer is populated by agent as training is carried out, updating the
dataset
* Applied autopep8 fixes
* * Updated line length from 120 to 110
* Update pl_examples/domain_templates/dqn.py
simplify get_device method
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* Update pl_examples/domain_templates/dqn.py
Re-ordered imports
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* CI: split tests-examples (#990 )
* CI: split tests-examples
* tests without template
* comment depends
* CircleCI typo
* add doctest
* update test req.
* CI tests
* setup macOS
* longer train
* lover pred acc
* fix model
* rename default model
* lower tests acc
* typo
* imports
* fix test optimizer
* update calls
* fix Win
* lower Drone image
* fix call
* pytorch image
* fix test
* add dev image
* add dev image
* update image
* drone volume
* lint
* update test notes
* rename tests/models >> tests/base
* group models
* conftest
* optim imports
* typos
* fix import
* fix tests
* install AMP
* tests
* fix import
* Clean up
* added module docstring
* renamed variables to be more descriptive
* Added missing docstrings and type annotations
* Added gym to example requirements
* Added note to changelog
* updated example image
* update types
* rename script
* Update CHANGELOG.md
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* another rename
* Disable validation when val_percent_check=0 (#1251 )
* fix disable validation
* add test
* update changelog
* update docs for val_percent_check
* make "fast training" docs consistent
* calling self.forward() -> self() (#1211 )
* self.forward() -> self()
* update changelog
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
* Fix requirements-extra.txt Trains package to release version (#1229 )
* Fix requirement-extra use released Trains package
* Update README.md add Trains and links to the external Visualization section
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
* Remove unnecessary parameters to super() in documentation and source code (#1240 )
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
* update deprecation warning (#1258 )
* update docs for progress bat values (#1253 )
* lower timeouts for inactive issues (#1250 )
* update contrib list (#1241 )
Co-authored-by: William Falcon <waf2107@columbia.edu >
* Fix outdated docs (#1227 )
* Fix typo (#1224 )
* drop unused Tox (#1242 )
* system info (#1234 )
* system info
* update big info
* test script
* update config
* rename script
* import path
* Changed smoothing in tqdm to decrease variability of time remaining between training / eval (#1194 )
* Example: Simple RL example using DQN/Lightning
* DQN RL Agent using Lightning
* Uses Iterable Dataset for Replay Buffer
* Buffer is populated by agent as training is carried out, updating the
dataset
* Applied autopep8 fixes
* * Updated line length from 120 to 110
* Update pl_examples/domain_templates/dqn.py
simplify get_device method
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* Update pl_examples/domain_templates/dqn.py
Re-ordered imports
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* Clean up
* added module docstring
* renamed variables to be more descriptive
* Added missing docstrings and type annotations
* Added gym to example requirements
* Added note to changelog
* update types
* rename script
* Update CHANGELOG.md
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com >
* another rename
Co-authored-by: Donal Byrne <Donal.Byrne@xperi.com >
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
Co-authored-by: William Falcon <waf2107@columbia.edu >
Co-authored-by: Adrian Wälchli <adrian.waelchli@students.unibe.ch >
Co-authored-by: Jeremy Jordan <13970565+jeremyjordan@users.noreply.github.com >
Co-authored-by: Martin.B <51887611+bmartinn@users.noreply.github.com >
Co-authored-by: Tyler Yep <tyep@stanford.edu >
Co-authored-by: Shunta Komatsu <59395084+skmatz@users.noreply.github.com >
Co-authored-by: Jack Pertschuk <jackpertschuk@gmail.com >
2020-03-28 16:10:53 -04:00
Justus Schock
4e0d0ab8d2
Update Contributors ( #1274 )
...
* Update Contributors in Readme
* Update Governance
2020-03-28 16:09:00 -04:00
Adrian Wälchli
0b0180406b
Fix outdated docs follow up ( #1266 )
...
* save_top_k
* num_gpus
* print_nan_grads fix leftovers
* undo doctest removal
2020-03-28 11:30:57 -04:00
Jack Pertschuk
12b39a74b4
Changed smoothing in tqdm to decrease variability of time remaining between training / eval ( #1194 )
2020-03-27 09:22:53 -04:00
Jirka Borovec
61177cd1c8
system info ( #1234 )
...
* system info
* update big info
* test script
* update config
* rename script
* import path
2020-03-27 08:45:52 -04:00
Jirka Borovec
1a9719c1c8
drop unused Tox ( #1242 )
2020-03-27 08:44:55 -04:00
Shunta Komatsu
ac6692d3e4
Fix typo ( #1224 )
2020-03-27 08:43:12 -04:00
Shunta Komatsu
3a93aaf9e2
Fix outdated docs ( #1227 )
2020-03-27 08:42:52 -04:00
Jirka Borovec and William Falcon
da185342ce
update contrib list ( #1241 )
...
Co-authored-by: William Falcon <waf2107@columbia.edu >
2020-03-27 08:42:14 -04:00
Jirka Borovec
9bb2e00cb6
lower timeouts for inactive issues ( #1250 )
2020-03-27 08:41:31 -04:00
Jirka Borovec
bec43c9f8a
update docs for progress bat values ( #1253 )
2020-03-27 08:41:07 -04:00
Jirka Borovec
593bf50759
update deprecation warning ( #1258 )
2020-03-27 08:40:47 -04:00
Tyler Yep and Jirka Borovec
6772e0c197
Remove unnecessary parameters to super() in documentation and source code ( #1240 )
...
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-03-27 12:36:50 +00:00
Martin.B and Jirka Borovec
6a0b171be4
Fix requirements-extra.txt Trains package to release version ( #1229 )
...
* Fix requirement-extra use released Trains package
* Update README.md add Trains and links to the external Visualization section
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-03-27 08:32:19 +01:00
Jeremy Jordan and Jirka Borovec
d394b80ac8
calling self.forward() -> self() ( #1211 )
...
* self.forward() -> self()
* update changelog
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com >
2020-03-27 08:17:56 +01:00
Adrian Wälchli
2a4cd479e2
Disable validation when val_percent_check=0 ( #1251 )
...
* fix disable validation
* add test
* update changelog
* update docs for val_percent_check
* make "fast training" docs consistent
2020-03-27 02:07:22 +00:00
William Falcon
e86e6b2faa
updated example image
2020-03-26 09:28:08 -04:00
