Reorganize ray_deps_setup.bzl to make all the GitHub rules uniform and download ZIP files for everything (#6193)

* Reorganize ray_deps_setup.bzl to make all the GitHub rules uniform

* Rewrite github_repository with explicit keyword-only arguments

Requires Bazel >= 0.29.0: https://github.com/bazelbuild/buildtools/pull/677
This commit is contained in:
mehrdadn
2019-11-22 09:59:32 -08:00
committed by Edward Oakes
parent eb6a93c0f0
commit 05ce789e5b
+117 -54
View File
@@ -1,131 +1,194 @@
load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository", "new_git_repository")
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
def github_repository(*, name=None, remote=None, commit=None, tag=None,
branch=None, build_file=None, build_file_content=None,
sha256=None, shallow_since=None, strip_prefix=True,
url=None, path=None, **kwargs):
"""
Conveniently chooses between archive, git, etc. GitHub repositories.
Prefer archives, as they're smaller and faster due to the lack of history.
One of {commit, tag, branch} must also be provided (as usual).
sha256 should be omitted (or None) when the archive hash is unknown, then
updated ASAP to allow caching & avoid repeated downloads on every build.
If remote == None , it is an error.
If name == None , it is auto-deduced, but this is NOT recommended.
If build_file == True , it is auto-deduced.
If strip_prefix == True , it is auto-deduced.
If url == None , it is auto-deduced.
If sha256 != False, uses archive download (recommended; fast).
If sha256 == False, uses git clone (NOT recommended; slow).
If path != None , local repository is assumed at the given path.
"""
GIT_SUFFIX = ".git"
archive_suffix = ".zip"
treeish = commit or tag or branch
if not treeish: fail("Missing commit, tag, or branch argument")
if remote == None: fail("Missing remote argument")
if remote.endswith(GIT_SUFFIX):
remote_no_suffix = remote[:len(remote) - len(GIT_SUFFIX)]
else:
remote_no_suffix = remote
project = remote_no_suffix.split("//", 1)[1].split("/")[2]
if name == None:
name = project.replace("-", "_")
if strip_prefix == True:
strip_prefix = "%s-%s" % (project, treeish)
if url == None:
url = "%s/archive/%s%s" % (remote_no_suffix, treeish, archive_suffix)
if build_file == True:
build_file = "@//%s:%s" % ("bazel", "BUILD." + name)
if path != None:
if build_file or build_file_content:
native.new_local_repository(name=name, path=path,
build_file=build_file,
build_file_content=build_file_content,
**kwargs)
else:
native.local_repository(name=name, path=path, **kwargs)
elif sha256 == False:
if build_file or build_file_content:
new_git_repository(name=name, remote=remote, build_file=build_file,
commit=commit, tag=tag, branch=branch,
shallow_since=shallow_since,
build_file_content=build_file_content,
strip_prefix=strip_prefix, **kwargs)
else:
git_repository(name=name, remote=remote, strip_prefix=strip_prefix,
commit=commit, tag=tag, branch=branch,
shallow_since=shallow_since, **kwargs)
else:
http_archive(name=name, url=url, sha256=sha256, build_file=build_file,
strip_prefix=strip_prefix,
build_file_content=build_file_content, **kwargs)
def ray_deps_setup():
RULES_JVM_EXTERNAL_TAG = "2.10"
RULES_JVM_EXTERNAL_SHA = "1bbf2e48d07686707dd85357e9a94da775e1dbd7c464272b3664283c9c716d26"
http_archive(
github_repository(
name = "rules_jvm_external",
sha256 = RULES_JVM_EXTERNAL_SHA,
strip_prefix = "rules_jvm_external-%s" % RULES_JVM_EXTERNAL_TAG,
url = "https://github.com/bazelbuild/rules_jvm_external/archive/%s.zip" % RULES_JVM_EXTERNAL_TAG,
tag = "2.10",
remote = "https://github.com/bazelbuild/rules_jvm_external",
sha256 = "1bbf2e48d07686707dd85357e9a94da775e1dbd7c464272b3664283c9c716d26",
)
http_archive(
github_repository(
name = "bazel_common",
strip_prefix = "bazel-common-f1115e0f777f08c3cdb115526c4e663005bec69b",
url = "https://github.com/google/bazel-common/archive/f1115e0f777f08c3cdb115526c4e663005bec69b.zip",
sha256 = "1e05a4791cc3470d3ecf7edb556f796b1d340359f1c4d293f175d4d0946cf84c",
commit = "f1115e0f777f08c3cdb115526c4e663005bec69b",
remote = "https://github.com/google/bazel-common",
sha256 = "1e05a4791cc3470d3ecf7edb556f796b1d340359f1c4d293f175d4d0946cf84c",
)
BAZEL_SKYLIB_TAG = "0.6.0"
http_archive(
github_repository(
name = "bazel_skylib",
strip_prefix = "bazel-skylib-%s" % BAZEL_SKYLIB_TAG,
url = "https://github.com/bazelbuild/bazel-skylib/archive/%s.tar.gz" % BAZEL_SKYLIB_TAG,
sha256 = "eb5c57e4c12e68c0c20bc774bfbc60a568e800d025557bc4ea022c6479acc867",
tag = "0.6.0",
remote = "https://github.com/bazelbuild/bazel-skylib",
sha256 = "54ee22e5b9f0dd2b42eb8a6c1878dee592cfe8eb33223a7dbbc583a383f6ee1a",
)
git_repository(
github_repository(
name = "com_github_checkstyle_java",
commit = "ef367030d1433877a3360bbfceca18a5d0791bdd",
remote = "https://github.com/ray-project/checkstyle_java",
shallow_since = "1573090990 -0800",
sha256 = "2fc33ec804011a03106e76ae77d7f1b09091b0f830f8e2a0408f079a032ed716",
)
git_repository(
github_repository(
name = "com_github_nelhage_rules_boost",
commit = "5171b9724fbb39c5fdad37b9ca9b544e8858d8ac",
remote = "https://github.com/ray-project/rules_boost",
shallow_since = "1556014830 +0800",
sha256 = "14fa5cb327a3df811aa8713bbb7c5a63a89286868e7ec874c4a335829bf9c018",
)
git_repository(
github_repository(
name = "com_github_google_flatbuffers",
commit = "63d51afd1196336a7d1f56a988091ef05deb1c62",
remote = "https://github.com/google/flatbuffers.git",
shallow_since = "1547755012 -0800",
remote = "https://github.com/google/flatbuffers",
sha256 = "dd87be0acf932c9b0d9b5d7bb49aec23e1c98bbd3327254bd90cb4af198f9332",
)
git_repository(
github_repository(
name = "com_google_googletest",
commit = "3306848f697568aacf4bcca330f6bdd5ce671899",
remote = "https://github.com/google/googletest",
shallow_since = "1534270723 -0700",
sha256 = "2625a1d301cd658514e297002170c2fc83a87beb0f495f943601df17d966511d",
)
git_repository(
github_repository(
name = "com_github_gflags_gflags",
remote = "https://github.com/gflags/gflags.git",
commit = "e171aa2d15ed9eb17054558e0b3a6a413bb01067",
shallow_since = "1541971260 +0000",
commit = "e171aa2d15ed9eb17054558e0b3a6a413bb01067",
remote = "https://github.com/gflags/gflags",
sha256 = "da72f0dce8e3422d0ab2fea8d03a63a64227b0376b3558fd9762e88de73b780b",
)
new_git_repository(
github_repository(
name = "com_github_google_glog",
build_file = "@//bazel:BUILD.glog",
commit = "96a2f23dca4cc7180821ca5f32e526314395d26a",
remote = "https://github.com/google/glog",
shallow_since = "1550458164 +0900",
sha256 = "6281aa4eeecb9e932d7091f99872e7b26fa6aacece49c15ce5b14af2b7ec050f",
)
new_git_repository(
github_repository(
name = "plasma",
build_file = "@//bazel:BUILD.plasma",
build_file = True,
commit = "86f34aa07e611787d9cc98c6a33b0a0a536dce57",
remote = "https://github.com/apache/arrow",
shallow_since = "1572492886 -0700",
sha256 = "4f1956e74188fa15078c8ad560bbc298624320d2aafd21fe7a2511afee7ea841",
)
new_git_repository(
github_repository(
name = "cython",
build_file = "@//bazel:BUILD.cython",
build_file = True,
commit = "49414dbc7ddc2ca2979d6dbe1e44714b10d72e7e",
remote = "https://github.com/cython/cython",
shallow_since = "1547888711 +0100",
sha256 = "aaee5dec23165ee10c189d8b40f19861e2c6929c015cee3d2b4e56d8a1bdc422",
)
http_archive(
github_repository(
name = "io_opencensus_cpp",
strip_prefix = "opencensus-cpp-3aa11f20dd610cb8d2f7c62e58d1e69196aadf11",
urls = ["https://github.com/census-instrumentation/opencensus-cpp/archive/3aa11f20dd610cb8d2f7c62e58d1e69196aadf11.zip"],
sha256 = "92eef77c44d01e8472f68a2f1329919a1bb59317a4bb1e4d76081ab5c13a56d6",
commit = "3aa11f20dd610cb8d2f7c62e58d1e69196aadf11",
remote = "https://github.com/census-instrumentation/opencensus-cpp",
sha256 = "92eef77c44d01e8472f68a2f1329919a1bb59317a4bb1e4d76081ab5c13a56d6",
)
# OpenCensus depends on Abseil so we have to explicitly pull it in.
# This is how diamond dependencies are prevented.
git_repository(
github_repository(
name = "com_google_absl",
commit = "aa844899c937bde5d2b24f276b59997e5b668bde",
remote = "https://github.com/abseil/abseil-cpp.git",
shallow_since = "1565288385 -0400",
remote = "https://github.com/abseil/abseil-cpp",
sha256 = "f1a959a2144f0482b9bd61e67a9897df02234fff6edf82294579a4276f2f4b97",
)
# OpenCensus depends on jupp0r/prometheus-cpp
git_repository(
github_repository(
name = "com_github_jupp0r_prometheus_cpp",
commit = "5c45ba7ddc0585d765a43d136764dd2a542bd495",
remote = "https://github.com/ray-project/prometheus-cpp",
# TODO(qwang): We should use the repository of `jupp0r` here when this PR
# `https://github.com/jupp0r/prometheus-cpp/pull/225` getting merged.
remote = "https://github.com/ray-project/prometheus-cpp.git",
shallow_since = "1572744904 -0700"
sha256 = "c80293276166d405188b1af62cd11178fbcec0f1a8ab0dbece19d4bdc79d45e7",
)
git_repository(
github_repository(
name = "com_github_grpc_grpc",
commit = "93e8830070e9afcbaa992c75817009ee3f4b63a0",
remote = "https://github.com/grpc/grpc.git",
shallow_since = "1571118670 -0700",
remote = "https://github.com/grpc/grpc",
sha256 = "b391a327429279f6f29b9ae7e5317cd80d5e9d49cc100e6d682221af73d984a6",
patches = [
"//thirdparty/patches:grpc-cython-copts.patch",
],
)
git_repository(
github_repository(
name = "rules_proto_grpc",
commit = "a74fef39c5fe636580083545f76d1eab74f6450d",
remote = "https://github.com/rules-proto-grpc/rules_proto_grpc.git",
shallow_since = "1571494564 +0100",
remote = "https://github.com/rules-proto-grpc/rules_proto_grpc",
sha256 = "53561ecacaebe58916dfdb962d889a56394d3fae6956e0bcd63c4353f813284a",
)