Remove all runtime errors. (#1840)

src/ray/object_manager/connection_pool.h

@@ -86,9 +86,7 @@ class ConnectionPool {
   ray::Status RemoveSender(ConnectionType type, std::shared_ptr<SenderConnection> conn);
 
   /// This object cannot be copied for thread-safety.
-  ConnectionPool &operator=(const ConnectionPool &o) {
-    throw std::runtime_error("Can't copy ConnectionPool.");
-  }
+  RAY_DISALLOW_COPY_AND_ASSIGN(ConnectionPool);
 
  private:
   /// A container type that maps ClientID to a connection type.

src/ray/object_manager/object_directory.h

@@ -110,10 +110,8 @@ class ObjectDirectory : public ObjectDirectoryInterface {
   /// Ray only (not part of the OD interface).
   ObjectDirectory(std::shared_ptr<gcs::AsyncGcsClient> gcs_client);
 
-  /// This object cannot be copied for thread-safety.
-  ObjectDirectory &operator=(const ObjectDirectory &o) {
-    throw std::runtime_error("Can't copy ObjectDirectory.");
-  }
+  /// ObjectDirectory should not be copied.
+  RAY_DISALLOW_COPY_AND_ASSIGN(ObjectDirectory);
 
  private:
   /// Callbacks associated with a call to GetLocations.

src/ray/object_manager/object_store_notification_manager.cc

@@ -47,7 +47,7 @@ void ObjectStoreNotificationManager::ProcessStoreLength(
 void ObjectStoreNotificationManager::ProcessStoreNotification(
     const boost::system::error_code &error) {
   if (error) {
-    throw std::runtime_error("ObjectStore may have died.");
+    RAY_LOG(FATAL) << error.message();
   }
 
   const auto &object_info = flatbuffers::GetRoot<ObjectInfo>(notification_.data());

src/ray/object_manager/test/object_manager_stress_test.cc

@@ -103,9 +103,7 @@ class TestObjectManagerBase : public ::testing::Test {
                                  " 1> /dev/null 2> /dev/null &";
     RAY_LOG(DEBUG) << plasma_command;
     int ec = system(plasma_command.c_str());
-    if (ec != 0) {
-      throw std::runtime_error("failed to start plasma store.");
-    };
+    RAY_CHECK(ec == 0);
     return store_id;
   }
 

src/ray/object_manager/test/object_manager_test.cc

@@ -94,9 +94,7 @@ class TestObjectManager : public ::testing::Test {
                                  " 1> /dev/null 2> /dev/null &";
     RAY_LOG(DEBUG) << plasma_command;
     int ec = system(plasma_command.c_str());
-    if (ec != 0) {
-      throw std::runtime_error("failed to start plasma store.");
-    };
+    RAY_CHECK(ec == 0);
     return store_id;
   }
 

src/ray/object_manager/transfer_queue.h

@@ -55,6 +55,8 @@ class TransferQueue {
     }
   };
 
+  TransferQueue() = default;
+
   /// Queues a send.
   ///
   /// \param client_id The ClientID to which the object needs to be sent.
@@ -103,9 +105,7 @@ class TransferQueue {
   ray::Status RemoveContext(const UniqueID &id);
 
   /// This object cannot be copied for thread-safety.
-  TransferQueue &operator=(const TransferQueue &o) {
-    throw std::runtime_error("Can't copy TransferQueue.");
-  }
+  RAY_DISALLOW_COPY_AND_ASSIGN(TransferQueue);
 
  private:
   // TODO(hme): make this a shared mutex.

src/ray/raylet/object_manager_integration_test.cc

@@ -24,9 +24,7 @@ class TestObjectManagerBase : public ::testing::Test {
                                  " 1> /dev/null 2> /dev/null &";
     RAY_LOG(INFO) << plasma_command;
     int ec = system(plasma_command.c_str());
-    if (ec != 0) {
-      throw std::runtime_error("failed to start plasma store.");
-    };
+    RAY_CHECK(ec == 0);
     return store_id;
   }