wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-07-20 12:40:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove transport type remnants (#8673)

Browse Source
This commit is contained in:
Edward Oakes
2020-05-29 15:47:08 -05:00
committed by GitHub
parent e5b6566d28
commit 4955d14878
2 changed files with 5 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ray/common/id.cc
-9
View File
@@ -60,10 +60,6 @@ constexpr uint8_t kCreatedByTaskBitsOffset = 15;
/// The bit offset of the flag `ObjectType` in a flags bytes.
constexpr uint8_t kObjectTypeBitsOffset = 14;
/// The bit offset of the flag `TransportType` in a flags bytes.
// TODO(edoakes): this isn't used anymore, should update ID layout.
// constexpr uint8_t kTransportTypeBitsOffset = 11;
/// The mask that is used to mask the flag `CreatedByTask`.
constexpr ObjectIDFlagsType kCreatedByTaskFlagBitMask = 0x1 << kCreatedByTaskBitsOffset;
@@ -71,11 +67,6 @@ constexpr ObjectIDFlagsType kCreatedByTaskFlagBitMask = 0x1 << kCreatedByTaskBit
/// So it can represent for 2 types.
constexpr ObjectIDFlagsType kObjectTypeFlagBitMask = 0x1 << kObjectTypeBitsOffset;
/// The mask that is used to mask 3 bits to indicate the type of transport.
// TODO(edoakes): this isn't used anymore, should update ID layout.
// constexpr ObjectIDFlagsType kTransportTypeFlagBitMask = 0x7 <<
// kTransportTypeBitsOffset;
/// The implementations of helper functions.
inline void SetCreatedByTaskFlag(bool created_by_task, ObjectIDFlagsType *flags) {
const ObjectIDFlagsType object_type_bits =
src/ray/design_docs/id_specification.md
+5 -7
View File
@@ -56,10 +56,10 @@ An `ObjectID` contains 3 parts:
**flags bytes format**
```
1b 1b 3b 11b
+-------------------------------------------------------------------------+
| (1) | (2) | (3) | (4)unused |
+-------------------------------------------------------------------------+
1b 1b 14b
+-------------------------------------------------------+
| (1) | (2) | (4)unused |
+-------------------------------------------------------+
```
- The (1) `created_by_task` part is one bit to indicate whether this `ObjectID` is generated (put or returned) from a task.
@@ -67,6 +67,4 @@ An `ObjectID` contains 3 parts:
- `PUT_OBJECT` indicates this object is generated through `ray.put` during the task's execution.
- `RETURN_OBJECT` indicates this object is the return value of a task.
- The (3) `transport_type` part is 3 bits to indicate the type of the transport which is used to transfer this object. So it can support 8 types.
- There are 11 bits unused in `flags bytes`.
- There are 14 bits unused in `flags bytes`.