[Core] Update the object manager pulling objects error message to warning. (#10657)

* Update the message to expose less implementation details and make the severity WARNING.

* Fix formatting.
This commit is contained in:
SangBin Cho
2020-09-11 15:53:04 -07:00
committed by GitHub
parent dbca2f9889
commit 517e164fb7
+11 -8
View File
@@ -230,10 +230,12 @@ void ObjectManager::TryPull(const ObjectID &object_id) {
// Make sure that there is at least one client which is not the local client.
// TODO(rkn): It may actually be possible for this check to fail.
if (node_vector.size() == 1 && node_vector[0] == self_node_id_) {
RAY_LOG(ERROR) << "The object manager with ID " << self_node_id_
<< " is trying to pull object " << object_id
<< " but the object table suggests that this object manager "
<< "already has the object. The object may have been evicted.";
RAY_LOG(WARNING) << "The object manager with ID " << self_node_id_
<< " is trying to pull object " << object_id
<< " but the object table suggests that this object manager "
<< "already has the object. The object may have been evicted. It is "
<< "most likely due to memory pressure, object pull has been "
<< "requested before object location is updated.";
it->second.timer_set = false;
return;
}
@@ -248,10 +250,11 @@ void ObjectManager::TryPull(const ObjectID &object_id) {
if (node_id == self_node_id_) {
std::swap(node_vector[node_index], node_vector[node_vector.size() - 1]);
node_vector.pop_back();
RAY_LOG(ERROR) << "The object manager with ID " << self_node_id_
<< " is trying to pull object " << object_id
<< " but the object table suggests that this object manager "
<< "already has the object.";
RAY_LOG(WARNING)
<< "The object manager with ID " << self_node_id_ << " is trying to pull object "
<< object_id << " but the object table suggests that this object manager "
<< "already has the object. It is most likely due to memory pressure, object "
<< "pull has been requested before object location is updated.";
node_id = node_vector[node_index % node_vector.size()];
RAY_CHECK(node_id != self_node_id_);
}