Fix placement group bug failing in release test (#10944)

This commit is contained in:
SangBin Cho
2020-09-23 12:37:28 -07:00
committed by GitHub
parent 5921e87ecd
commit 7931b6ce2e
2 changed files with 3 additions and 1 deletions
@@ -126,7 +126,8 @@ void GcsPlacementGroupManager::OnPlacementGroupCreationFailed(
// registered.
auto state = placement_group->GetState();
RAY_CHECK(state == rpc::PlacementGroupTableData::RESCHEDULING ||
state == rpc::PlacementGroupTableData::PENDING)
state == rpc::PlacementGroupTableData::PENDING ||
state == rpc::PlacementGroupTableData::REMOVED)
<< "State: " << state;
if (state == rpc::PlacementGroupTableData::RESCHEDULING) {
// NOTE: If a node is dead, the placement group scheduler should try to recover the
@@ -237,6 +237,7 @@ TEST_F(GcsPlacementGroupManagerTest, TestRemovingLeasingPlacementGroup) {
gcs_placement_group_manager_->RemovePlacementGroup(placement_group_id,
[](Status status) {});
ASSERT_EQ(placement_group->GetState(), rpc::PlacementGroupTableData::REMOVED);
gcs_placement_group_manager_->OnPlacementGroupCreationFailed(placement_group);
// Make sure it is not rescheduled
gcs_placement_group_manager_->SchedulePendingPlacementGroups();