wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-07-01 17:11:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

[New scheduler] Also unsubscribe get dependencies on unblock

Browse Source
This commit is contained in:
Eric Liang
2020-12-15 20:29:44 -08:00
committed by GitHub
parent a7caa14d3d
commit 7ff314a5df
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ray/raylet/node_manager.cc
+9 -9
View File
@@ -2181,6 +2181,15 @@ void NodeManager::HandleDirectCallTaskBlocked(
void NodeManager::HandleDirectCallTaskUnblocked(
const std::shared_ptr<WorkerInterface> &worker) {
if (!worker || worker->GetAssignedTaskId().IsNil()) {
return; // The worker may have died or is no longer processing the task.
}
TaskID task_id = worker->GetAssignedTaskId();
// First, always release task dependencies. This ensures we don't leak resources even
// if we don't need to unblock the worker below.
task_dependency_manager_.UnsubscribeGetDependencies(task_id);
if (new_scheduler_enabled_) {
// Important: avoid double unblocking if the unblock RPC finishes after task end.
if (!worker || !worker->IsBlocked()) {
@@ -2200,15 +2209,6 @@ void NodeManager::HandleDirectCallTaskUnblocked(
return;
}
if (!worker || worker->GetAssignedTaskId().IsNil()) {
return; // The worker may have died or is no longer processing the task.
}
TaskID task_id = worker->GetAssignedTaskId();
// First, always release task dependencies. This ensures we don't leak resources even
// if we don't need to unblock the worker below.
task_dependency_manager_.UnsubscribeGetDependencies(task_id);
if (!worker->IsBlocked()) {
return; // Don't need to unblock the worker.
}