wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-08-11 11:24:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

[GCS]Fix redis store client AsyncPutWithIndex unordered bug (#13002)

Browse Source
This commit is contained in:
fangfengbin
2020-12-21 20:02:50 +08:00
committed by GitHub
parent c576f0b073
commit 85a4435ba0
1 changed files with 17 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ray/gcs/store_client/redis_store_client.cc
+17 -22
View File
@@ -38,29 +38,24 @@ Status RedisStoreClient::AsyncPutWithIndex(const std::string &table_name,
const std::string &index_key,
const std::string &data,
const StatusCallback &callback) {
auto write_callback = [this, table_name, key, data, callback](Status status) {
if (!status.ok()) {
// Run callback if failed.
if (callback != nullptr) {
callback(status);
}
return;
}
// Write data to Redis.
status = DoPut(GenRedisKey(table_name, key), data, callback);
if (!status.ok()) {
// Run callback if failed.
if (callback != nullptr) {
callback(status);
}
}
};
// NOTE: To ensure the atomicity of `AsyncPutWithIndex`, we can't write data to Redis in
// the callback function of index writing.
// Write index to Redis.
std::string index_table_key = GenRedisKey(table_name, key, index_key);
return DoPut(index_table_key, key, write_callback);
const auto &index_table_key = GenRedisKey(table_name, key, index_key);
RAY_CHECK_OK(DoPut(index_table_key, key, nullptr));
// Write data to Redis.
// The operation of redis client is executed in order, and it can ensure that index is
// written first and then data is written. The index and data are decoupled, so we don't
// need to write data in the callback function of index writing.
const auto &status = DoPut(GenRedisKey(table_name, key), data, callback);
if (!status.ok()) {
// Run callback if failed.
if (callback != nullptr) {
callback(status);
}
}
return status;
}
Status RedisStoreClient::AsyncGet(const std::string &table_name, const std::string &key,