mirror of
https://github.com/wassname/ray.git
synced 2026-06-27 20:06:31 +08:00
[rllib] Deprecate custom preprocessors (#6833)
* deprecation warnings * add log warn * fix test
This commit is contained in:
Eric Liang
+7
-6
@@ -163,18 +163,19 @@ script:
|
||||
- if [ $RAY_CI_SERVE_AFFECTED == "1" ]; then python -m pytest -v --durations=5 --timeout=300 python/ray/experimental/serve/tests; fi
|
||||
- if [ $RAY_CI_SERVE_AFFECTED == "1" ]; then ./ci/suppress_output python python/ray/experimental/serve/examples/echo_full.py; fi
|
||||
|
||||
# ray tests
|
||||
- if [ $RAY_CI_PYTHON_AFFECTED == "1" ]; then RAY_FORCE_DIRECT=0 python -m pytest -v --durations=5 --timeout=300 python/ray/experimental/test/async_test.py; fi
|
||||
- if [ $RAY_CI_PYTHON_AFFECTED == "1" ]; then python -m pytest -v --durations=5 --timeout=300 python/ray/tests/py3_test.py; fi
|
||||
|
||||
- ./ci/keep_alive bazel test --spawn_strategy=local --flaky_test_attempts=3 --nocache_test_results --test_verbose_timeout_warnings --progress_report_interval=100 --show_progress_rate_limit=100 --show_timestamps --test_output=errors --test_tag_filters=-jenkins_only python/ray/...
|
||||
|
||||
# ray operator tests
|
||||
- cd ./deploy/ray-operator/
|
||||
- go build
|
||||
- go test ./...
|
||||
- cd ../..
|
||||
|
||||
# bazel python tests. This should be run last to keep its logs at the end of travis logs.
|
||||
- if [ $RAY_CI_PYTHON_AFFECTED == "1" ]; then RAY_FORCE_DIRECT=0 python -m pytest -v --durations=5 --timeout=300 python/ray/experimental/test/async_test.py; fi
|
||||
- if [ $RAY_CI_PYTHON_AFFECTED == "1" ]; then python -m pytest -v --durations=5 --timeout=300 python/ray/tests/py3_test.py; fi
|
||||
|
||||
- ./ci/keep_alive bazel test --spawn_strategy=local --flaky_test_attempts=3 --nocache_test_results --test_verbose_timeout_warnings --progress_report_interval=100 --show_progress_rate_limit=100 --show_timestamps --test_output=errors --test_tag_filters=-jenkins_only python/ray/...
|
||||
# NO MORE TESTS BELOW, keep them above.
|
||||
|
||||
deploy:
|
||||
- provider: s3
|
||||
edge: true # This supposedly opts in to deploy v2.
|
||||
|
||||
@@ -139,7 +139,11 @@ Once implemented, the model can then be registered and used in place of a built-
|
||||
Custom Preprocessors
|
||||
--------------------
|
||||
|
||||
Custom preprocessors should subclass the RLlib `preprocessor class <https://github.com/ray-project/ray/blob/master/rllib/models/preprocessors.py>`__ and be registered in the model catalog. Note that you can alternatively use `gym wrapper classes <https://github.com/openai/gym/tree/master/gym/wrappers>`__ around your environment instead of preprocessors.
|
||||
.. warning::
|
||||
|
||||
Custom preprocessors are deprecated, since they sometimes conflict with the built-in preprocessors for handling complex observation spaces. Please use `wrapper classes <https://github.com/openai/gym/tree/master/gym/wrappers>`__ around your environment instead of preprocessors.
|
||||
|
||||
Custom preprocessors should subclass the RLlib `preprocessor class <https://github.com/ray-project/ray/blob/master/rllib/models/preprocessors.py>`__ and be registered in the model catalog:
|
||||
|
||||
.. code-block:: python
|
||||
|
||||
|
||||
@@ -74,14 +74,15 @@ MODEL_DEFAULTS = {
|
||||
"zero_mean": True,
|
||||
|
||||
# === Options for custom models ===
|
||||
# Name of a custom preprocessor to use
|
||||
"custom_preprocessor": None,
|
||||
# Name of a custom model to use
|
||||
"custom_model": None,
|
||||
# Name of a custom action distribution to use
|
||||
"custom_action_dist": None,
|
||||
# Extra options to pass to the custom classes
|
||||
"custom_options": {},
|
||||
# Custom preprocessors are deprecated. Please use a wrapper class around
|
||||
# your environment instead to preprocess observations.
|
||||
"custom_preprocessor": None,
|
||||
}
|
||||
# __sphinx_doc_end__
|
||||
# yapf: enable
|
||||
@@ -364,6 +365,12 @@ class ModelCatalog:
|
||||
if options.get("custom_preprocessor"):
|
||||
preprocessor = options["custom_preprocessor"]
|
||||
logger.info("Using custom preprocessor {}".format(preprocessor))
|
||||
logger.warning(
|
||||
"DeprecationWarning: Custom preprocessors are deprecated, "
|
||||
"since they sometimes conflict with the built-in "
|
||||
"preprocessors for handling complex observation spaces. "
|
||||
"Please use wrapper classes around your environment "
|
||||
"instead of preprocessors.")
|
||||
prep = _global_registry.get(RLLIB_PREPROCESSOR, preprocessor)(
|
||||
observation_space, options)
|
||||
else:
|
||||
|
||||
@@ -3,31 +3,8 @@
|
||||
# inherently high variance, so you'll have to check to see if the
|
||||
# rewards reached seem reasonably in line with previous results.
|
||||
#
|
||||
# The reference results for 0.7.6 are as follows:
|
||||
# +----------------------------------------+------------+-----------+--------+------------------+-------------+----------+
|
||||
# | Trial name | status | loc | iter | total time (s) | timesteps | reward |
|
||||
# |----------------------------------------+------------+-----------+--------+------------------+-------------+----------|
|
||||
# | IMPALA_BreakoutNoFrameskip-v4_1acd2414 | TERMINATED | pid=32600 | 296 | 3606.77 | 7152000 | 296.42 |
|
||||
# | IMPALA_BreakoutNoFrameskip-v4_1acdd4ea | TERMINATED | pid=32604 | 296 | 3606.33 | 7096500 | 337.74 |
|
||||
# | IMPALA_BreakoutNoFrameskip-v4_1ace550a | TERMINATED | pid=32628 | 296 | 3605.84 | 7140000 | 353.77 |
|
||||
# | IMPALA_BreakoutNoFrameskip-v4_1acec238 | TERMINATED | pid=32592 | 296 | 3606.5 | 7111000 | 376.08 |
|
||||
# | PPO_BreakoutNoFrameskip-v4_1acf6b7a | TERMINATED | pid=32581 | 606 | 3602.28 | 3030000 | 19.2 |
|
||||
# | PPO_BreakoutNoFrameskip-v4_1acff068 | TERMINATED | pid=32580 | 595 | 3602.06 | 2975000 | 26.39 |
|
||||
# | PPO_BreakoutNoFrameskip-v4_1ad08af0 | TERMINATED | pid=53836 | 594 | 3604.43 | 2970000 | 67.88 |
|
||||
# | PPO_BreakoutNoFrameskip-v4_1ad10ad4 | TERMINATED | pid=53869 | 594 | 3601.85 | 2970000 | 28.07 |
|
||||
# | APEX_BreakoutNoFrameskip-v4_1ad190f8 | TERMINATED | pid=32605 | 114 | 3622.9 | 4689280 | 30.86 |
|
||||
# | APEX_BreakoutNoFrameskip-v4_1ad24f34 | TERMINATED | pid=53855 | 114 | 3621.4 | 4519840 | 28.53 |
|
||||
# | APEX_BreakoutNoFrameskip-v4_1ad2d530 | TERMINATED | pid=53891 | 114 | 3618.97 | 4512000 | 31.59 |
|
||||
# | APEX_BreakoutNoFrameskip-v4_1ad34dc6 | TERMINATED | pid=53894 | 114 | 3626.85 | 4547360 | 26.49 |
|
||||
# | A2C_BreakoutNoFrameskip-v4_1ad40824 | TERMINATED | pid=59452 | 351 | 3607.43 | 3625500 | 29.32 |
|
||||
# | A2C_BreakoutNoFrameskip-v4_1ad47fac | TERMINATED | pid=59422 | 351 | 3607.31 | 3625500 | 29.05 |
|
||||
# | A2C_BreakoutNoFrameskip-v4_1ad4e5c8 | TERMINATED | pid=59414 | 351 | 3607.11 | 3630000 | 32.25 |
|
||||
# | A2C_BreakoutNoFrameskip-v4_1ad5984c | TERMINATED | pid=59199 | 351 | 3610.29 | 3631500 | 26.82 |
|
||||
# | DQN_BreakoutNoFrameskip-v4_1ad621cc | TERMINATED | pid=53851 | 24 | 3693.75 | 240000 | 12.89 |
|
||||
# | DQN_BreakoutNoFrameskip-v4_1ad69cb0 | TERMINATED | pid=53860 | 24 | 3681.93 | 240000 | 14.72 |
|
||||
# | DQN_BreakoutNoFrameskip-v4_1ad75c5e | TERMINATED | pid=53864 | 24 | 3662.21 | 240000 | 13.84 |
|
||||
# | DQN_BreakoutNoFrameskip-v4_1ad7d42c | TERMINATED | pid=53885 | 24 | 3697.62 | 240000 | 11.22 |
|
||||
# +----------------------------------------+------------+-----------+--------+------------------+-------------+----------+
|
||||
# You can find the reference results here:
|
||||
# https://github.com/ray-project/ray/tree/master/doc/dev/release_logs
|
||||
atari-impala:
|
||||
env: BreakoutNoFrameskip-v4
|
||||
run: IMPALA
|
||||
|
||||
Reference in New Issue
Block a user