mirror of
https://github.com/wassname/ray.git
synced 2026-06-27 21:08:13 +08:00
ActorStatisticalData() debug metrics bog down raylet with 100% CPU (#12148)
* comment out bad * update
This commit is contained in:
@@ -51,7 +51,8 @@ This document describes the process for creating new releases.
|
||||
|
||||
**IMPORTANT**: check that the test are actually running (printing output regularly) and aren't
|
||||
just stuck at an iteration. You must also check that the node CPU usage is stable
|
||||
(and not increasing or decreasing over time, which indicates a leak).
|
||||
(and not increasing or decreasing over time, which indicates a leak). You can see the head node
|
||||
and worker node CPU utilizations in the AWS console.
|
||||
|
||||
3. Multi-node regression tests
|
||||
|
||||
|
||||
@@ -44,6 +44,8 @@ struct ActorStats {
|
||||
ActorStats GetActorStatisticalData(
|
||||
std::unordered_map<ray::ActorID, ray::raylet::ActorRegistration> actor_registry) {
|
||||
ActorStats item;
|
||||
/* TODO(ekl) this gets slower and slower over time since we never clean up dead actors.
|
||||
* https://github.com/ray-project/ray/issues/11239
|
||||
for (auto &pair : actor_registry) {
|
||||
if (pair.second.GetState() == ray::rpc::ActorTableData::ALIVE) {
|
||||
item.live_actors += 1;
|
||||
@@ -53,6 +55,7 @@ ActorStats GetActorStatisticalData(
|
||||
item.dead_actors += 1;
|
||||
}
|
||||
}
|
||||
*/
|
||||
return item;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user