wassname/ray
1
0
Fork 0
mirror of https://github.com/wassname/ray.git synced 2026-06-27 17:49:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Fix passing env on windows (#13253)" (#13828)

Browse Source
This commit is contained in:
fyrestone
2021-02-05 13:03:16 +08:00
committed by GitHub
parent 8a5999c12a
commit eee624cf5f
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ray/util/process.cc
-9
View File
@@ -139,15 +139,6 @@ class ProcessFD {
STARTUPINFO si = {sizeof(si)};
RAY_UNUSED(
new_env_block.c_str()); // Ensure there's a final terminator for Windows
// MSDN:
// https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessa
// Note that an ANSI environment block is terminated by two zero bytes:
// one for the last string, one more to terminate the block.
// A Unicode environment block is terminated by four zero bytes:
// two for the last string, two more to terminate the block.
if (!new_env_block.empty()) {
new_env_block += '\0';
}
char *const envp = &new_env_block[0];
if (CreateProcessA(NULL, cmdline, NULL, NULL, FALSE, 0, envp, NULL, &si, &pi)) {
succeeded = true;