Merge pull request #1944 from sciunto/temp_file

MAINT: fixes #1652
2026-07-21 12:50:27 +08:00 · 2016-02-16 17:59:55 +11:00
parent 2217dfc6f2 461b06a517
commit dd5a5e5556
1 changed files with 4 additions and 3 deletions
@@ -24,10 +24,11 @@ def file_or_url_context(resource_name):
    """Yield name of file from the given resource (i.e. file or url)."""
    if is_url(resource_name):
        _, ext = os.path.splitext(resource_name)
-        with tempfile.NamedTemporaryFile(delete=False, suffix=ext) as f:
-            u = urlopen(resource_name)
-            f.write(u.read())
        try:
+            with tempfile.NamedTemporaryFile(delete=False, suffix=ext) as f:
+                u = urlopen(resource_name)
+                f.write(u.read())
+            # f must be closed before yielding
            yield f.name
        finally:
            os.remove(f.name)