Merge pull request #9 from benjycui/fix-bug

修复动画导致 Slider 滑块偏移的 Bug。

.gitignore

@@ -19,10 +19,8 @@ Thumbs.db
 *.pyo
 .build
 node_modules
-_site
-sea-modules
-spm_modules
 .cache
 dist
 assets/**/*.css
-build/
+build
+lib

.jscsrc

@@ -1,27 +0,0 @@
-{
-    "requireCurlyBraces": ["if", "else", "for", "while", "do", "try", "catch"],
-    "requireSpaceAfterKeywords": ["if", "else", "for", "while", "do", "switch", "return", "try", "catch"],
-    "requireSpacesInFunctionExpression": {
-        "beforeOpeningCurlyBrace": true
-    },
-    "disallowSpacesInsideArrayBrackets": true,
-    "disallowSpacesInsideObjectBrackets": true,
-    "disallowSpacesInsideParentheses": true,
-    "disallowQuotedKeysInObjects": "allButReserved",
-    "disallowSpaceAfterObjectKeys": true,
-    "requireSpaceBeforeBinaryOperators": ["-", "/", "*", "=", "==", "===", "!=", "!==", ">", ">=", "<", "<=" ],
-    "requireSpacesInConditionalExpression": {
-        "afterTest": true,
-        "beforeConsequent": true,
-        "afterConsequent": true,
-        "beforeAlternate": true
-    },
-    "requireSpaceAfterBinaryOperators": ["/", "*", "=", "==", "===", "!=", "!==", ">", ">=", "<", "<="],
-    "disallowKeywords": [ "with" ],
-    "disallowSpaceAfterPrefixUnaryOperators": [ "!" , "++", "--", "+", "-", "~"],
-    "disallowSpaceBeforePostfixUnaryOperators": ["++", "--", ","],
-    "disallowMultipleLineBreaks": true,
-    "disallowKeywordsOnNewLine": ["else"],
-    "safeContextKeyword": "self",
-    "excludeFiles": ["lib/**/parser.js"]
-}

.jshintrc

@@ -1,28 +0,0 @@
-{
-    "camelcase": true,
-    "curly": true,
-    "eqeqeq": true,
-    "freeze": true,
-    "indent": 4,
-    "latedef": "nofunc",
-    "quotmark": "false",
-    "nonew": true,
-    "newcap": false,
-    "immed": true,
-    "noarg": true,
-    "eqnull": true,
-    "trailing": true,
-    "undef": true,
-    "unused": true,
-    "browser": true,
-    "node": true,
-    "esnext": true,
-    "globals": {
-        "describe": false,
-        "expect": false,
-        "beforeEach": false,
-        "afterEach": false,
-        "modulex": false,
-        "it": false
-    }
-}

.npmignore

@@ -1,7 +1,5 @@
-bower_components/
 build/
 *.cfg
-node_modules/
 nohup.out
 *.iml
 .idea/
@@ -22,8 +20,10 @@ Thumbs.db
 out/
 .build
 node_modules
-_site
-sea-modules
-spm_modules
 .cache
-dist
+examples
+tests
+src
+/index.js
+.*
+assets/**/*.less

HISTORY.md

@@ -0,0 +1,9 @@
+# History
+----
+
+
+## 1.2.5 / 2015-07-13
+
+[#8](https://github.com/react-component/slider/issues/8) add `isIncluded` props   ([@simaQ](https://github.com/simaQ))
+
+[#7](https://github.com/react-component/slider/issues/7) add tooltip for handler when slider has no `marks` props   ([@simaQ](https://github.com/simaQ))

README.md

@@ -106,6 +106,12 @@ React.render(<Rcslider />, container);
           <td>[]</td>
           <td>mark every step for the slider, it will ignore the `step` parameter if it has been defined</td>
         </tr>
+        <tr>
+          <td>isIncluded</td>
+          <td>boolean</td>
+          <td>true</td>
+          <td>if the value is true, it means a continuous value interval, otherwise, it is a independent value.</td>
+        </tr>
         <tr>
           <td>index</td>
           <td>number</td>

assets/index.less

@@ -1,21 +1,32 @@
 @prefixClass: rc-slider;
 
-// color
-@disabledColor: #e7eaec;
+@disabledColor: #ccc;
+@border-radius-base: 6px;
+@primary-color: #2db7f5;
+
+* {
+  box-sizing: border-box;
+  -webkit-tap-highlight-color: rgba(0, 0, 0, 0); //  remove tap highlight color for mobile safari
+}
+
+*:before,
+*:after {
+  box-sizing: border-box;
+}
 
 .@{prefixClass} {
   position: relative;
   height: 4px;
   width: 100%;
-  border-radius: 2px;
+  border-radius: @border-radius-base;
   background-color: #e9e9e9;
 
   &-track {
     position: absolute;
     left: 0;
     height: 4px;
-    border-radius: 2px;
-    background-color: #b2e9fd;
+    border-radius: @border-radius-base;
+    background-color: tint(@primary-color, 60%);
     z-index: 1;
   }
 
@@ -23,26 +34,21 @@
     position: absolute;
     margin-left: -7px;
     margin-top: -5px;
-    width: 10px;
-    height: 10px;
-    cursor: default;
+    width: 14px;
+    height: 14px;
+    cursor: pointer;
     border-radius: 50%;
-    border: solid 2px #d9d9d9;
+    border: solid 2px tint(@primary-color, 50%);
     background-color: #fff;
     z-index: 2;
 
     &:hover {
-      border-color: #999;
+      border-color: tint(@primary-color, 20%);
     }
     &-active {
-      border-color: #8cddfc;
       &:active {
-        border-color: #2db7f5;
-        background-color: #2db7f5;
-        box-shadow: 0 0 3px rgba(45, 183, 245, .75);
-      }
-      &:hover {
-        border-color: #23c0fa;
+        border-color: tint(@primary-color, 20%);
+        box-shadow: 0 0 5px tint(@primary-color, 20%);
       }
     }
   }
@@ -50,9 +56,8 @@
   &-mark {
     position: absolute;
     top: 10px;
-    left: 0px;
+    left: 0;
     width: 100%;
-    height: 20px;
     font-size: 12px;
     z-index: 3;
   }
@@ -60,17 +65,13 @@
   &-mark-text {
     position: absolute;
     display: inline-block;
-    line-height: 1.5;
-    height: 20px;
     vertical-align: middle;
     text-align: center;
     cursor: pointer;
-    color: #ccc;
-    &:first-child {
-      text-align: left;
-    }
+    color: #999;
+
     &-active {
-      color: #999;
+      color: #666;
     }
   }
 
@@ -86,21 +87,21 @@
     position: absolute;
     top: -2px;
     margin-left: -4px;
-    width: 4px;
-    height: 4px;
-    border: 2px solid #fff;
-    background-color: #bcbcbc;
+    width: 8px;
+    height: 8px;
+    border: 2px solid #e9e9e9;
+    background-color: #fff;
     cursor: pointer;
     border-radius: 50%;
     vertical-align: middle;
     &:first-child {
-      margin-left: -2px;
+      margin-left: -4px;
     }
     &:last-child {
-      margin-left: -6px;
+      margin-left: -4px;
     }
     &-active {
-      background-color: #8cddfc;
+      border-color: tint(@primary-color, 50%);
     }
   }
 

examples/simple.js

@@ -1,6 +1,7 @@
-/** @jsx React.DOM */
-// use jsx to render html, do not modify simple.html
+'use strict';
+
 require('rc-slider/assets/index.css');
+require('rc-tooltip/assets/bootstrap.css');
 var Slider = require('rc-slider');
 var React = require('react');
 // React.render(<Slider marks={["一","二","三","四","五"]} index={3}/>, document.getElementById('__react-content'));

index.js

@@ -1 +1,3 @@
-module.exports = require('./lib/Slider');
+'use strict';
+
+module.exports = require('./src/');

lib/EventListener.js

@@ -1,56 +0,0 @@
-/**
- * Copyright 2013-2014 Facebook, Inc.
- *
- * This file contains a modified version of:
- * https://github.com/facebook/react/blob/v0.12.0/src/vendor/stubs/EventListener.js
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- * TODO: remove in favour of solution provided by:
- *  https://github.com/facebook/react/issues/285
- */
-
-/**
- * Does not take into account specific nature of platform.
- */
-'use strict';
-
-var EventListener = {
-  /**
-   * Listen to DOM events during the bubble phase.
-   *
-   * @param {DOMEventTarget} target DOM element to register listener on.
-   * @param {string} eventType Event type, e.g. 'click' or 'mouseover'.
-   * @param {function} callback Callback function.
-   * @return {object} Object with a `remove` method.
-   */
-  listen: function listen(target, eventType, callback) {
-    if (target.addEventListener) {
-      target.addEventListener(eventType, callback, false);
-      return {
-        remove: function remove() {
-          target.removeEventListener(eventType, callback, false);
-        }
-      };
-    } else if (target.attachEvent) {
-      target.attachEvent('on' + eventType, callback);
-      return {
-        remove: function remove() {
-          target.detachEvent('on' + eventType, callback);
-        }
-      };
-    }
-  }
-};
-
-module.exports = EventListener;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "rc-slider",
-  "version": "1.0.0",
+  "version": "1.2.5",
   "description": "slider ui component for react",
   "keywords": [
     "react",
@@ -18,21 +18,18 @@
     "url": "http://github.com/react-component/slider/issues"
   },
   "licenses": "MIT",
-  "spm": {
-    "dependencies": {
-      "react": "*"
-    }
-  },
+  "main": "./lib/index.js",
   "config": {
     "port": 8000
   },
   "scripts": {
     "build": "rc-tools run build",
+    "precommit": "rc-tools run precommit",
     "less": "rc-tools run less",
     "gh-pages": "rc-tools run gh-pages",
     "history": "rc-tools run history",
-    "start": "node-dev --harmony node_modules/.bin/rc-server",
-    "publish": "spm publish && rc-tools run tag",
+    "start": "node --harmony node_modules/.bin/rc-server",
+    "publish": "rc-tools run tag",
     "lint": "rc-tools run lint",
     "saucelabs": "node --harmony node_modules/.bin/rc-tools run saucelabs",
     "browser-test": "node --harmony node_modules/.bin/rc-tools run browser-test",
@@ -40,19 +37,18 @@
   },
   "devDependencies": {
     "expect.js": "0.3.x",
-    "precommit-hook": "1.x",
-    "rc-server": "2.x",
-    "rc-tools": "2.x",
-    "react": "0.13.x",
+    "precommit-hook": "^1.0.7",
+    "rc-server": "3.x",
+    "rc-tools": "3.x",
+    "react": "^0.13.x",
     "node-dev": "2.x",
-    "jquery": "^1.11.2",
-    "css-loader": "^0.9.1"
+    "jquery": "^1.11.2"
   },
   "precommit": [
-    "lint",
-    "less"
+    "precommit"
   ],
   "dependencies": {
+    "rc-tooltip": "^2.4.0",
     "rc-util": "^2.0.2"
   }
 }

src/Slider.jsx

@@ -1,5 +1,7 @@
-/** @jsx React.DOM */
+'use strict';
+
 var React = require('react');
+var Tooltip = require('rc-tooltip');
 var DomUtils = require('rc-util').Dom;
 
 function pauseEvent(e) {
@@ -9,9 +11,6 @@ function pauseEvent(e) {
   if (e.preventDefault) {
     e.preventDefault();
   }
-  e.cancelBubble = true;
-  e.returnValue = false;
-  return false;
 }
 
 function prefixClsFn(prefixCls) {
@@ -29,6 +28,7 @@ var Slider = React.createClass({
     value: React.PropTypes.number,
     index: React.PropTypes.number,
     marks: React.PropTypes.array,
+    isIncluded: React.PropTypes.bool,
     className: React.PropTypes.string,
     disabled: React.PropTypes.bool,
     onBeforeChange: React.PropTypes.func,
@@ -43,6 +43,7 @@ var Slider = React.createClass({
       step: 1,
       value: 0,
       marks: [],
+      isIncluded: true,
       className: 'rc-slider',
       disabled: false,
       index: 0
@@ -89,10 +90,10 @@ var Slider = React.createClass({
   getIndex: function() {
     var props = this.props;
     if (props.marks.length === 0) {
-      return;
+      return 0;
     }
     var value = this.state.value;
-    var unit = (props.max - props.min) / (props.marks.length - 1);
+    var unit = ((props.max - props.min) / (props.marks.length - 1)).toFixed(5);
     return Math.floor(value / unit);
   },
 
@@ -129,7 +130,7 @@ var Slider = React.createClass({
   },
 
   _calValueByPos: function (position, callback) {
-    var pixelOffset = position - this.state.sliderStart;
+    var pixelOffset = position - this.getSliderStart();
     // pixelOffset -= (this.state.handleSize / 2);
 
     var nextValue = this._trimAlignValue(this._calcValue(pixelOffset));
@@ -141,6 +142,11 @@ var Slider = React.createClass({
     return e.pageX || (e.clientX + document.documentElement.scrollLeft);
   },
 
+  _getTouchPosition: function (e) {
+    var touch = e.touches[0];
+    return touch.pageX;
+  },
+
   _triggerEvents: function(event) {
     var props = this.props;
     var hasMarks = props.marks && props.marks.length > 0;
@@ -149,17 +155,27 @@ var Slider = React.createClass({
     }
   },
 
-  _addEventHandles: function() {
-    this._onMouseMoveListener = DomUtils.addEventListener(document, 'mousemove', this._onMouseMove);
-    this._onMouseUpListener = DomUtils.addEventListener(document, 'mouseup', this._onMouseUp);
-  },
-
-  _removeEventHandles: function () {
-    if (this._onMouseMoveListener) {
-      this._onMouseMoveListener.remove();
+  _addEventHandles: function(type) {
+    if (type === 'touch') {
+      // just work for chrome iOS Safari and Android Browser
+      this._onTouchMoveListener = DomUtils.addEventListener(document, 'touchmove', this._onTouchMove);
+      this._onTouchUpListener = DomUtils.addEventListener(document, 'touchend', this._onTouchUp);
     }
 
-    if (this._onMouseUpListener) {
+    if (type === 'mouse') {
+      this._onMouseMoveListener = DomUtils.addEventListener(document, 'mousemove', this._onMouseMove);
+      this._onMouseUpListener = DomUtils.addEventListener(document, 'mouseup', this._onMouseUp);
+    }
+  },
+
+  _removeEventHandles: function (type) {
+    if (type === 'touch') {
+      this._onTouchMoveListener.remove();
+      this._onTouchUpListener.remove();
+    }
+
+    if (type === 'mouse') {
+      this._onMouseMoveListener.remove();
       this._onMouseUpListener.remove();
     }
   },
@@ -177,18 +193,37 @@ var Slider = React.createClass({
     });
   },
 
-  _end: function() {
-    this._removeEventHandles();
+  _end: function(type) {
+    this._removeEventHandles(type);
     this.setState(this._triggerEvents.bind(this, 'onAfterChange'));
   },
 
   _onMouseUp: function() {
-    this._end();
+    this._end('mouse');
+  },
+
+  _onTouchUp: function() {
+    this._end('touch');
   },
 
   _onMouseMove: function(e) {
-    pauseEvent(e);
     var position = this._getMousePosition(e);
+    this._handleMove(e, position);
+  },
+
+  _onTouchMove: function(e) {
+    if (e.touches.length > 1 || (e.type === 'touchend' && e.touches.length > 0)) {
+      return;
+    }
+
+    var position = this._getTouchPosition(e);
+
+    this._handleMove(e, position);
+  },
+
+  _handleMove: function(e, position) {
+    pauseEvent(e);
+    // var position = this._getMousePosition(e);
     var props = this.props;
     var state = this.state;
 
@@ -203,7 +238,7 @@ var Slider = React.createClass({
     value = newValue;
 
     if (newValue !== oldValue) {
-      this.setState({value: value, active: 'active'} ,this._triggerEvents.bind(this, 'onChange'));
+      this.setState({value: value, active: 'active'}, this._triggerEvents.bind(this, 'onChange'));
     }
   },
 
@@ -216,11 +251,29 @@ var Slider = React.createClass({
 
     this.setState({
       upperBound: slider.clientWidth,
-      sliderLength: Math.abs(sliderMax - sliderMin),
-      sliderStart: sliderMin
+      sliderLength: Math.abs(sliderMax - sliderMin)
     });
   },
 
+  getSliderStart: function() {
+    var slider = this.refs.slider.getDOMNode();
+    var rect = slider.getBoundingClientRect();
+
+    return rect.left;
+  },
+
+  handleTouchStart: function(e) {
+    if (this.props.disabled || e.touches.length > 1 || (e.type === 'touchend' && e.touches.length > 0)) {
+      return;
+    }
+
+    var position = this._getTouchPosition(e);
+    this.startPosition = position;
+    this._start(position);
+    this._addEventHandles('touch');
+    pauseEvent(e);
+  },
+
   handleMouseDown: function() {
     return (e) => {
       if (this.props.disabled) {
@@ -228,7 +281,7 @@ var Slider = React.createClass({
       }
       var position = this._getMousePosition(e);
       this._start(position);
-      this._addEventHandles();
+      this._addEventHandles('mouse');
       pauseEvent(e);
     };
   },
@@ -242,9 +295,10 @@ var Slider = React.createClass({
       () => {
         this._triggerEvents('onChange');
         this._start(position);
-        this._addEventHandles();
+        this._addEventHandles('mouse');
       }
     );
+
     pauseEvent(e);
   },
 
@@ -264,11 +318,16 @@ var Slider = React.createClass({
         left: offset.toFixed(5)
       };
       var className = prefixClsFn(prefixCls, 'dot');
-      if (i <= this.getIndex() || (this._calcValue(offset) <= this.getValue())) {
-        className = prefixClsFn(prefixCls, 'dot', 'dot-active');
+      if (props.isIncluded) {
+        if (i <= this.getIndex() || (this._calcValue(offset) <= this.getValue())) {
+          className = prefixClsFn(prefixCls, 'dot', 'dot-active');
+        }
+      } else {
+        className = (i === this.getIndex()) ? prefixClsFn(prefixCls, 'dot', 'dot-active') : className;
       }
+
       elements[i] = (
-        <span className={className} style={style} ref={'step'+i}></span>
+        <span className={className} style={style} ref={'step' + i}></span>
       );
     }
 
@@ -289,18 +348,21 @@ var Slider = React.createClass({
       width: (unit / 2).toFixed(5)
     };
 
-    if (i === (marksLen - 1)) {
-      style.right = '0';
-      style.width = 'auto';
-    }else {
-      style.left = (i > 0 ? (offset - (unit / 4)).toFixed(5) : offset);
+    if (i === marksLen - 1) {
+      style.right = -(style.width / 2).toFixed(5);
+    } else {
+      style.left = i > 0 ? (offset - unit / 4).toFixed(5) : -(style.width / 2).toFixed(5);
     }
 
     var prefixCls = this.props.className;
     var className = prefixClsFn(prefixCls, 'mark-text');
 
-    if (i <= this.getIndex()) {
-      className = prefixClsFn(prefixCls, 'mark-text', 'mark-text-active');
+    if (this.props.isIncluded) {
+      if (i <= this.getIndex()) {
+        className = prefixClsFn(prefixCls, 'mark-text', 'mark-text-active');
+      }
+    } else {
+      className = (i === this.getIndex()) ? prefixClsFn(prefixCls, 'mark-text', 'mark-text-active') : className;
     }
 
     return (
@@ -338,13 +400,22 @@ var Slider = React.createClass({
       className =  prefixClsFn(prefixCls, 'handle', 'handle-active');
     }
 
-    return (
-      <a className={className}
+    var handle =  <a className={className}
         ref = "handle"
         style = {handleStyle}
         href = "#"
-        onMouseDown={this.handleMouseDown}></a>
-    );
+        onMouseDown = {this.handleMouseDown}
+        onTouchStart = {this.handleTouchStart}></a>;
+
+    if (this.props.marks.length > 0) {
+      return handle;
+    } else {
+      return (
+        <Tooltip placement="top" overlay={<span>{this.state.value}</span>} delay={0} >
+          {handle}
+        </Tooltip>
+      );
+    }
   },
 
   renderTrack: function(offset) {
@@ -367,7 +438,7 @@ var Slider = React.createClass({
     var value = state.value;
     var offset = this._calcOffset(value);
 
-    var track = this.renderTrack(offset);
+    var track = this.props.isIncluded ? this.renderTrack(offset) : null;
     var handles = this.renderHandle(offset);
     var steps = (props.step > 1 || props.marks.length > 0) ? this.renderSteps() : null;
     var sliderMarks = (props.marks.length > 0) ? this.renderMarks() : null;
@@ -381,6 +452,7 @@ var Slider = React.createClass({
         {handles}
         {steps}
         {sliderMarks}
+        {this.props.children}
       </div>
     );
   }

src/index.js

@@ -0,0 +1,3 @@
+'use strict';
+
+module.exports = require('./Slider');

tests/index.spec.js

@@ -1,4 +1,5 @@
-/** @jsx React.DOM */
+'use strict';
+
 var expect = require('expect.js');
 var Slider = require('../index.js');
 var React = require('react');
@@ -72,4 +73,4 @@ describe('rc-slider', function () {
     }, 200);
   });
 
-});
+});