wassname/sloth
1
0
Fork 0
mirror of https://github.com/wassname/sloth.git synced 2026-06-27 18:25:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

remove more mutable default arguments

Browse Source
This commit is contained in:
Martin Baeuml
2014-03-19 14:32:09 +01:00
parent 9bb08470cc
commit a811b9cccf
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sloth/annotations/model.py
+8 -5
View File
@@ -286,11 +286,13 @@ class RootModelItem(ModelItem):
if hasattr(child, 'getAnnotations')]
class KeyValueModelItem(ModelItem, MutableMapping):
def __init__(self, hidden=[], properties=None):
def __init__(self, hidden=None, properties=None):
ModelItem.__init__(self)
self._dict = {}
self._items = {}
self._hidden = hidden + [None, 'class', 'unlabeled', 'unconfirmed']
self._dict = {}
self._items = {}
self._hidden = set(hidden or [])
self._hidden.update({None, 'class', 'unlabeled', 'unconfirmed'})
# dummy key/value so that pyqt does not convert the dict
# into a QVariantMap while communicating with the Views
self._dict[None] = None
@@ -396,7 +398,8 @@ class KeyValueModelItem(ModelItem, MutableMapping):
self._emitDataChanged('unconfirmed')
class FileModelItem(KeyValueModelItem):
def __init__(self, fileinfo, hidden=['filename']):
def __init__(self, fileinfo, hidden=None):
if not hidden: hidden = ['filename']
KeyValueModelItem.__init__(self, hidden=hidden, properties=fileinfo)
def data(self, role=Qt.DisplayRole, column=0):
sloth/gui/buttonarea.py
+2 -2
View File
@@ -141,9 +141,9 @@ class ButtonArea(QWidget):
else:
button_list.hide()
def add_label(self, label_name, properties = {}):
def add_label(self, label_name, properties=None):
self.label_names.append(label_name)
self.label_properties[label_name] = properties
self.label_properties[label_name] = properties or {}
for key, value in properties.items():
if key in self.properties:
self.properties[key] = unique_list(self.properties[key] + value)