cleaner method chain per review

2026-08-14 12:50:17 +08:00 · 2017-10-31 16:50:35 -07:00
parent 5e7ee344ec
commit 21f6caa942
1 changed files with 5 additions and 3 deletions
@@ -14,9 +14,11 @@ function isUserFlagged(actions) {

 function getUserFlaggedType(actions) {
  return actions
-    .filter((action) => action.__typename === 'FlagAction' && action.user)
-    .map((action) => action.user.roles.some((role) => staffRoles.includes(role)))
-    .some((staff) => staff) ? 'Staff' : 'User';
+    .some((action) =>
+      action.__typename === 'FlagAction' &&
+      action.user &&
+      action.user.roles.some((role) => staffRoles.includes(role))
+    ) ? 'Staff' : 'User';
 }

 function hasSuspectedWords(actions) {