wassname/talk
1
0
Fork 0
mirror of https://github.com/wassname/talk.git synced 2026-08-03 13:20:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

only trigger a re-flow when the height actually changes

Browse Source
This commit is contained in:
Riley Davis
2017-03-02 12:27:31 -07:00
parent d04b230b3f
commit 2246728c80
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/coral-embed/src/index.js
+5 -4
View File
@@ -31,13 +31,14 @@ function buildStreamIframeUrl(talkBaseUrl, asset_url, comment, asset_id) {
function configurePymParent(pymParent, asset_url) {
let notificationOffset = 200;
let ready = false;
let cachedHeight;
// Resize parent iframe height when child height changes
pymParent.onMessage('height', function(height) {
// TODO: In local testing, this is firing nonstop. Maybe there's a bug on the inside?
// Or it's by design of pym... but that's very wasteful of CPU and DOM reflows (jank)
pymParent.el.querySelector('iframe').height = `${height }px`;
if (height !== cachedHeight) {
pymParent.el.querySelector('iframe').height = `${height }px`;
cachedHeight = height;
}
});
// Helps child show notifications at the right scrollTop