Removes duplicate func and adds tests.

This commit is contained in:
gaba
2017-01-31 14:04:31 -08:00
parent 37eae51641
commit 282c7dc4f5
3 changed files with 27 additions and 22 deletions
+2 -2
View File
@@ -98,7 +98,7 @@ class Embed extends Component {
<Tab>Settings</Tab>
<Tab restricted={!isAdmin}>Configure Stream</Tab>
</TabBar>
{loggedIn && <UserBox user={user} logout={this.props.logout} />}
{loggedIn && user && <UserBox user={user} logout={this.props.logout} />}
<TabContent show={activeTab === 0}>
{
asset.closedAt === null
@@ -130,7 +130,7 @@ class Embed extends Component {
: <p>{asset.settings.closedMessage}</p>
}
{!loggedIn && <SignInContainer offset={signInOffset}/>}
{loggedIn && <ChangeDisplayNameContainer loggedIn={loggedIn} offset={signInOffset} user={user}/>}
{loggedIn && user && <ChangeDisplayNameContainer loggedIn={loggedIn} offset={signInOffset} user={user} />}
<Stream
refetch={refetch}
addNotification={this.props.addNotification}
+6 -20
View File
@@ -156,18 +156,6 @@ module.exports = class UsersService {
});
}
static changeDisplayName(id, displayName) {
return UsersService.isValidDisplayName(displayName)
.then((displayName) => { // displayName is valid
return UserModel.update({id}, {
$inc: {__v: 1},
$set: {
displayName: displayName
}
});
});
}
/**
* Creates local users.
* @param {Array} users Users to create
@@ -366,14 +354,12 @@ module.exports = class UsersService {
*/
static setDisplayName(id, displayName) {
// Check to see if that the displayName is not empty.
if (displayName.length < 1) {
// User displayName is required! Error out here.
return Promise.reject(new Error('display name should not be empty'));
}
return UserModel.update({id}, {$set: {'displayName': displayName}});
return UsersService.isValidDisplayName(displayName)
.then((displayName) => { // displayName is valid
return UserModel.update(
{id},
{$set: {'displayName': displayName}});
});
}
/**
+19
View File
@@ -178,6 +178,25 @@ describe('services.UsersService', () => {
});
});
describe('#setDisplayName', () => {
it('should set the display name to a new unique one', () => {
return UsersService
.setDisplayName(mockUsers[0].id, 'maria')
.then(() => UsersService.findById(mockUsers[0].id))
.then((user) => {
expect(user).to.have.property('displayName', 'maria');
});
});
it('should return an error when the displayName is not unique', () => {
return UsersService
.setDisplayName(mockUsers[0].id, 'marvel')
.catch((error) => {
expect(error).to.not.be.null;
});
});
});
describe('#ban', () => {
it('should set the status to banned', () => {
return UsersService