wassname/talk
1
0
Fork 0
mirror of https://github.com/wassname/talk.git synced 2026-08-07 11:29:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

v4 - Adding live updates for accepted comments (#2584)

Browse Source 
* First pass at live updates for accepted comments

* fix: logic cleanup
This commit is contained in:
Joe Simon
2019-09-30 23:47:30 +00:00
committed by Wyatt Johnson
parent 4445479237
commit 41c9ae32b1
3 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
graph/subscriptions/setupFunctions.js
+8 -4
View File
@@ -8,7 +8,7 @@ const {
SUBSCRIBE_ALL_USERNAME_CHANGED,
SUBSCRIBE_ALL_USERNAME_FLAGGED,
SUBSCRIBE_ALL_USERNAME_REJECTED,
SUBSCRIBE_COMMENT_ACCEPTED,
SUBSCRIBE_ALL_COMMENT_ACCEPTED,
SUBSCRIBE_COMMENT_FLAGGED,
SUBSCRIBE_COMMENT_REJECTED,
SUBSCRIBE_COMMENT_RESET,
@@ -64,10 +64,14 @@ const setupFunctions = {
return !args.asset_id || comment.asset_id === args.asset_id;
},
commentAccepted: (options, args, comment, context) => {
if (!context.user || !context.user.can(SUBSCRIBE_COMMENT_ACCEPTED)) {
return false;
if (args.asset_id) {
// Allow sending back the comment for the user that has filtered based
// on a specific asset.
return comment.asset_id === args.asset_id;
} else {
// Only privileged users can subscribe to all assets.
return context.user && context.user.can(SUBSCRIBE_ALL_COMMENT_ACCEPTED);
}
return !args.asset_id || comment.asset_id === args.asset_id;
},
commentRejected: (options, args, comment, context) => {
if (!context.user || !context.user.can(SUBSCRIBE_COMMENT_REJECTED)) {
perms/constants/subscription.js
+1 -1
View File
@@ -1,5 +1,5 @@
module.exports = {
SUBSCRIBE_COMMENT_ACCEPTED: 'SUBSCRIBE_COMMENT_ACCEPTED',
SUBSCRIBE_ALL_COMMENT_ACCEPTED: 'SUBSCRIBE_ALL_COMMENT_ACCEPTED',
SUBSCRIBE_COMMENT_REJECTED: 'SUBSCRIBE_COMMENT_REJECTED',
SUBSCRIBE_COMMENT_FLAGGED: 'SUBSCRIBE_COMMENT_FLAGGED',
SUBSCRIBE_COMMENT_RESET: 'SUBSCRIBE_COMMENT_RESET',
perms/reducers/subscription.js
+1 -1
View File
@@ -4,7 +4,7 @@ const types = require('../constants');
module.exports = (user, perm) => {
switch (perm) {
case types.SUBSCRIBE_COMMENT_FLAGGED:
case types.SUBSCRIBE_COMMENT_ACCEPTED:
case types.SUBSCRIBE_ALL_COMMENT_ACCEPTED:
case types.SUBSCRIBE_COMMENT_REJECTED:
case types.SUBSCRIBE_COMMENT_RESET:
case types.SUBSCRIBE_ALL_COMMENT_EDITED: