add a perms utils file

models/user.js

@@ -163,7 +163,7 @@ UserSchema.index({
  * returns true if a commenter is staff
  */
 UserSchema.method('isStaff', function () {
-  return !!intersection(['ADMIN', 'MODERATOR', 'STAFF'], this.roles).length;
+  return intersection(['ADMIN', 'MODERATOR', 'STAFF'], this.roles).length !== 0;
 });
 
 /**

perms/mutationReducer.js

@@ -1,7 +1,4 @@
-const intersection = require('lodash/intersection');
-const check = (user, roles) => {
-  return !!intersection(roles, user.roles).length;
-};
+const {check} = require('./utils');
 
 module.exports = {
   CREATE_COMMENT: 'CREATE_COMMENT',

perms/queryReducer.js

@@ -1,7 +1,4 @@
-const intersection = require('lodash/intersection');
-const check = (user, roles) => {
-  return !!intersection(roles, user.roles).length;
-};
+const {check} = require('./utils');
 
 module.exports = {
   SEARCH_ASSETS: 'SEARCH_ASSETS',

perms/rootReducer.js

@@ -1,15 +1,9 @@
 module.exports = {
-  DUMMY_ROLE: 'DUMMY_ROLE',
-  checkRoles: function (user, perm) {
+  checkRoles: function (user /* , perm*/) {
 
     // this runs before everything
     if (user.status === 'BANNED') {
       return false;
     }
-
-    switch (perm) {
-    default:
-      break;
-    }
   }
 };

perms/utils.js

@@ -0,0 +1,8 @@
+const intersection = require('lodash/intersection');
+const check = (user, roles) => {
+  return intersection(roles, user.roles).length > 0;
+};
+
+module.exports = {
+  check
+};

services/users.js

@@ -389,9 +389,6 @@ module.exports = class UsersService {
       return Promise.reject(new Error(`role ${role} is not supported`));
     }
 
-    // 5.11.2017 - Restricting this to a hierarchical system like WordPress
-    // where you can only set one role at a time.
-    // I'm not changing the data structure here, because I don't want a migration
     return UserModel.update({id}, {$set: {roles: [role]}});
   }