wassname/talk
1
0
Fork 0
mirror of https://github.com/wassname/talk.git synced 2026-07-14 11:18:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove findById in error conditions of CommentsService@addTag,removeTag

Browse Source
This commit is contained in:
Benjamin Goering
2017-03-01 14:09:03 +08:00
parent 4b2cc72e1a
commit b0036ef778
1 changed files with 3 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/comments.js
+3 -17
View File
@@ -73,14 +73,8 @@ module.exports = class CommentsService {
switch (nModified) {
case 0:
// either the tag was already there, or the comment doesn't exist with that id...
return this.findById(id)
.then(result => {
if ( ! result) {
throw new Error(`Can't add tag to comment. There is no comment with id ${id}`);
}
throw new Error(`Can't add tag ${name} to comment. Comment already has that tag.`);
});
// either the tag was already there, or the comment doesn't exist with that id...
throw new Error('Could not add tag to comment. Either the comment doesn\'t exist or the tag is already present.');
case 1:
// tag added
@@ -108,15 +102,7 @@ module.exports = class CommentsService {
.then(({nModified}) => {
switch (nModified) {
case 0:
// either the tag was already there, or the comment doesn't exist with that id...
return this.findById(id)
.then(result => {
if ( ! result) {
throw new Error(`Can't remove tag from comment. There is no comment with id ${id}`);
}
throw new Error(`Can't remove tag ${name} from comment. Comment doesn't have that tag.`);
});
throw new Error('Could not remove tag from comment. Either the comment doesn\'t exist or the tag is not present');
case 1:
// tag removed