Merged master into banned-optimize-bug

client/coral-embed-stream/src/Embed.js

@@ -16,7 +16,7 @@ import {queryStream} from 'coral-framework/graphql/queries';
 import {postComment, postFlag, postLike, postDontAgree, deleteAction, addCommentTag, removeCommentTag} from 'coral-framework/graphql/mutations';
 import {editName} from 'coral-framework/actions/user';
 import {updateCountCache} from 'coral-framework/actions/asset';
-import {Notification, notificationActions, authActions, assetActions, pym} from 'coral-framework';
+import {notificationActions, authActions, assetActions, pym} from 'coral-framework';
 
 import Stream from './Stream';
 import InfoBox from 'coral-plugin-infobox/InfoBox';
@@ -176,7 +176,7 @@ class Embed extends Component {
                 refetch={refetch}
                 setActiveReplyBox={this.setActiveReplyBox}
                 activeReplyBox={this.state.activeReplyBox}
-                addNotification={addNotification}
+                addNotification={this.props.addNotification}
                 depth={0}
                 postItem={this.props.postItem}
                 asset={asset}
@@ -220,11 +220,6 @@ class Embed extends Component {
                 showSignInDialog={this.props.showSignInDialog}
                 comments={asset.comments} />
             </div>
-            <Notification
-              notifLength={4500}
-              clearNotification={this.props.clearNotification}
-              notification={{text: null}}
-            />
           <LoadMore
             assetId={asset.id}
             comments={asset.comments}
@@ -246,11 +241,6 @@ class Embed extends Component {
              />
            </RestrictedContent>
          </TabContent>
-          <Notification
-            notifLength={4500}
-            clearNotification={this.props.clearNotification}
-            notification={this.props.notification}
-          />
         </div>
       </div>
     );
@@ -258,7 +248,6 @@ class Embed extends Component {
 }
 
 const mapStateToProps = state => ({
-  notification: state.notification.toJS(),
   auth: state.auth.toJS(),
   userData: state.user.toJS(),
   asset: state.asset.toJS()
@@ -267,13 +256,7 @@ const mapStateToProps = state => ({
 const mapDispatchToProps = dispatch => ({
   requestConfirmEmail: () => dispatch(requestConfirmEmail()),
   loadAsset: (asset) => dispatch(fetchAssetSuccess(asset)),
-  addNotification: (type, text) => {
-    pym.sendMessage('getPosition');
-
-    pym.onMessage('position', position => {
-      dispatch(addNotification(type, text, position));
-    });
-  },
+  addNotification: (type, text) => dispatch(addNotification(type, text)),
   clearNotification: () => dispatch(clearNotification()),
   editName: (username) => dispatch(editName(username)),
   showSignInDialog: (offset) => dispatch(showSignInDialog(offset)),

client/coral-embed/src/index.js

@@ -1,5 +1,26 @@
 import pym from 'pym.js';
 
+const snackbarStyles = {
+  position: 'fixed',
+  cursor: 'default',
+  userSelect: 'none',
+  backgroundColor: '#323232',
+  zIndex: 3,
+  willChange: 'transform, opacity',
+  transition: 'transform .35s cubic-bezier(.55,0,.1,1), opacity .35s',
+  pointerEvents: 'none',
+  padding: '12px 18px',
+  color: '#fff',
+  borderRadius: '3px 3px 0 0',
+  textAlign: 'center',
+  maxWidth: '300px',
+  left: '50%',
+  opacity: 0,
+  transform: 'translate(-50%, 20px)',
+  bottom: 0,
+  boxSizing: 'border-box'
+};
+
 // This function should return value of window.Coral
 const Coral = {};
 const Talk = Coral.Talk = {};
@@ -32,6 +53,14 @@ function configurePymParent(pymParent, asset_url) {
   let notificationOffset = 200;
   let ready = false;
   let cachedHeight;
+  const snackbar = document.createElement('div');
+  snackbar.id = 'coral-notif';
+
+  for (let key in snackbarStyles) {
+    snackbar.style[key] = snackbarStyles[key];
+  }
+
+  window.document.body.appendChild(snackbar);
 
   // Resize parent iframe height when child height changes
   pymParent.onMessage('height', function(height) {
@@ -41,6 +70,27 @@ function configurePymParent(pymParent, asset_url) {
     }
   });
 
+  pymParent.onMessage('coral-clear-notification', function () {
+    snackbar.style.opacity = 0;
+  });
+
+  pymParent.onMessage('coral-alert', function (message) {
+    const [type, text] = message.split('|');
+    snackbar.style.transform = 'translate(-50%, 20px)';
+    snackbar.style.opacity = 0;
+    snackbar.className = `coral-notif-${type}`;
+    snackbar.textContent = text;
+
+    setTimeout(() => {
+      snackbar.style.transform = 'translate(-50%, 0)';
+      snackbar.style.opacity = 1;
+    }, 0);
+
+    setTimeout(() => {
+      snackbar.style.opacity = 0;
+    }, 5000);
+  });
+
   // Helps child show notifications at the right scrollTop
   pymParent.onMessage('getPosition', function() {
     let position = viewport().height + document.body.scrollTop;

client/coral-framework/actions/notification.js

@@ -1,17 +1,9 @@
-export const ADD_NOTIFICATION = 'ADD_NOTIFICATION';
-export const CLEAR_NOTIFICATION = 'CLEAR_NOTIFICATION';
+import {pym} from 'coral-framework';
 
-export const addNotification = (notifType, text, position) => {
-  return {
-    type: ADD_NOTIFICATION,
-    notifType,
-    text,
-    position
-  };
+export const addNotification = (notifType, text) => {
+  pym.sendMessage('coral-alert', `${notifType}|${text}`);
 };
 
 export const clearNotification = () => {
-  return {
-    type: CLEAR_NOTIFICATION
-  };
+  pym.sendMessage('coral-clear-notification');
 };

client/coral-framework/index.js

@@ -4,7 +4,6 @@ import I18n from './modules/i18n/i18n';
 import * as authActions from './actions/auth';
 import * as assetActions from './actions/asset';
 import * as notificationActions from './actions/notification';
-import Notification from './modules/notification/Notification';
 
 export {
   pym,
@@ -12,6 +11,5 @@ export {
   store,
   authActions,
   assetActions,
-  Notification,
   notificationActions
 };

client/coral-framework/modules/notification/Notification.js

@@ -1,22 +0,0 @@
-import React from 'react';
-import {SnackBar} from 'coral-ui';
-
-const Notification = (props) => {
-  if (props.notification.text) {
-    setTimeout(() => {
-      props.clearNotification();
-    }, props.notifLength);
-  }
-  return (
-    <div>
-      {
-        props.notification.text &&
-        <SnackBar id='coral-notif' className={`coral-notif-${props.notification.type}`} position={props.notification.position}>
-          {props.notification.text}
-        </SnackBar>
-      }
-    </div>
-  );
-};
-
-export default Notification;

client/coral-framework/reducers/index.js

@@ -1,11 +1,9 @@
 import auth from './auth';
 import user from './user';
 import asset from './asset';
-import notification from './notification';
 
 export default {
   auth,
   user,
   asset,
-  notification
 };

client/coral-framework/reducers/notification.js

@@ -1,24 +0,0 @@
-import * as actions from '../actions/notification';
-import {Map} from 'immutable';
-
-const initialState = Map({
-  text: '',
-  type: '',
-  position: 400
-});
-
-export default (state = initialState, action) => {
-  switch (action.type) {
-  case actions.ADD_NOTIFICATION:
-    return state
-      .merge({
-        type: action.notifType,
-        text: action.text,
-        position: action.position
-      });
-  case actions.CLEAR_NOTIFICATION:
-    return initialState;
-  default:
-    return state;
-  }
-};

client/coral-plugin-replies/ReplyBox.js

@@ -1,21 +1,29 @@
-import React, {PropTypes} from 'react';
+import React, {Component, PropTypes} from 'react';
 import CommentBox from '../coral-plugin-commentbox/CommentBox';
 
 const name = 'coral-plugin-replies';
 
-const ReplyBox = ({styles, postItem, assetId, authorId, addNotification, parentId, commentPostedHandler, setActiveReplyBox}) => (
-  <div className={`${name}-textarea`} style={styles && styles.container}>
-    <CommentBox
-      commentPostedHandler={commentPostedHandler}
-      parentId={parentId}
-      cancelButtonClicked={setActiveReplyBox}
-      addNotification={addNotification}
-      authorId={authorId}
-      assetId={assetId}
-      postItem={postItem}
-      isReply={true} />
-  </div>
-);
+class ReplyBox extends Component {
+
+  componentDidMount() {
+    document.getElementById('replyText').focus();
+  }
+
+  render() {
+    const {styles, postItem, assetId, authorId, addNotification, parentId, commentPostedHandler, setActiveReplyBox} = this.props;
+    return <div className={`${name}-textarea`} style={styles && styles.container}>
+      <CommentBox
+        commentPostedHandler={commentPostedHandler}
+        parentId={parentId}
+        cancelButtonClicked={setActiveReplyBox}
+        addNotification={addNotification}
+        authorId={authorId}
+        assetId={assetId}
+        postItem={postItem}
+        isReply={true} />
+    </div>;
+  }
+}
 
 ReplyBox.propTypes = {
   setActiveReplyBox: PropTypes.func.isRequired,

test/client/coral-framework/reducers/notificationReducer.spec.js

@@ -1,35 +0,0 @@
-import {Map} from 'immutable';
-import {expect} from 'chai';
-import notificationReducer from '../../../../client/coral-framework/reducers/notification';
-import * as actions from '../../../../client/coral-framework/actions/notification';
-
-describe ('notificationsReducer', () => {
-  describe('ADD_NOTIFICATION', () => {
-    it('should add a notification', () => {
-      const action = {
-        type: actions.ADD_NOTIFICATION,
-        text: 'Test notification',
-        notifType: 'test'
-      };
-      const store = new Map({});
-      const result = notificationReducer(store, action);
-      expect(result.get('text')).to.equal(action.text);
-      expect(result.get('type')).to.equal(action.notifType);
-    });
-  });
-
-  describe('CLEAR_NOTIFICATION', () => {
-    it('should clear a notification', () => {
-      const action = {
-        type: actions.CLEAR_NOTIFICATION
-      };
-      const store = new Map({
-        text: 'Test notification',
-        type: 'test'
-      });
-      const result = notificationReducer(store, action);
-      expect(result.get('text')).to.equal('');
-      expect(result.get('type')).to.equal('');
-    });
-  });
-});

test/client/coral-framework/store/notificationReducer.spec.js

@@ -1,35 +0,0 @@
-import {Map} from 'immutable';
-import {expect} from 'chai';
-import notificationReducer from '../../../../client/coral-framework/reducers/notification';
-import * as actions from '../../../../client/coral-framework/actions/notification';
-
-describe ('notificationsReducer', () => {
-  describe('ADD_NOTIFICATION', () => {
-    it('should add a notification', () => {
-      const action = {
-        type: actions.ADD_NOTIFICATION,
-        text: 'Test notification',
-        notifType: 'test'
-      };
-      const store = new Map({});
-      const result = notificationReducer(store, action);
-      expect(result.get('text')).to.equal(action.text);
-      expect(result.get('type')).to.equal(action.notifType);
-    });
-  });
-
-  describe('CLEAR_NOTIFICATION', () => {
-    it('should clear a notification', () => {
-      const action = {
-        type: actions.CLEAR_NOTIFICATION
-      };
-      const store = new Map({
-        text: 'Test notification',
-        type: 'test'
-      });
-      const result = notificationReducer(store, action);
-      expect(result.get('text')).to.equal('');
-      expect(result.get('type')).to.equal('');
-    });
-  });
-});