reintroduced the errors.ErrSameUsernameProvided

errors.js

@@ -59,6 +59,11 @@ const ErrUsernameTaken = new APIError('Username already in use', {
   status: 400
 });
 
+const ErrSameUsernameProvided = new APIError('Username provided for change is the same as current', {
+  translation_key: 'SAME_USERNAME_PROVIDED',
+  status: 400
+});
+
 const ErrSpecialChars = new APIError('No special characters are allowed in a username', {
   translation_key: 'NO_SPECIAL_CHARACTERS',
   status: 400
@@ -245,5 +250,6 @@ module.exports = {
   ErrSettingsNotInit,
   ErrSpecialChars,
   ErrUsernameTaken,
+  ErrSameUsernameProvided,
   ExtendableError,
 };

services/users.js

@@ -281,7 +281,7 @@ class UsersService {
         }
 
         if (!resetAllowed && user.username === username) {
-          throw errors.ErrUsernameTaken;
+          throw errors.ErrSameUsernameProvided;
         }
 
         throw new Error('edit username failed for an unexpected reason');

test/server/services/users.js

@@ -238,7 +238,7 @@ describe('services.UsersService', () => {
             await UsersService[func](user.id, user.username);
             throw new Error('edit was processed successfully');
           } catch (err) {
-            expect(err).have.property('translation_key', 'USERNAME_IN_USE');
+            expect(err).have.property('translation_key', 'SAME_USERNAME_PROVIDED');
           }
         } else {
           await UsersService[func](user.id, user.username);