Merge pull request #208 from coralproject/fix/dialog-unmount

Check if dialog is present before removing listeners
This commit is contained in:
Gabriela Rodríguez Berón
2017-01-03 11:40:31 -03:00
committed by GitHub
2 changed files with 4 additions and 4 deletions
@@ -25,9 +25,7 @@ export default class CommentList extends React.Component {
loading: PropTypes.bool,
// list of actions (flags, etc) associated with the comments
actions: PropTypes.shape({
ids: PropTypes.arrayOf(PropTypes.string)
}),
actions: PropTypes.arrayOf(PropTypes.string),
suspectWords: PropTypes.arrayOf(PropTypes.string)
}
+3 -1
View File
@@ -42,7 +42,9 @@ export default class Dialog extends Component {
componentWillUnmount() {
const dialog = this.dialog;
dialog.removeEventListener('cancel', this.props.onCancel);
if (dialog) {
dialog.removeEventListener('cancel', this.props.onCancel);
}
}
render() {