Follow review comments

This commit is contained in:
keisuke-umezawa
2024-05-29 21:29:18 +09:00
parent 3507b5497b
commit c2751cb3ec
2 changed files with 8 additions and 8 deletions
+3 -3
View File
@@ -86,13 +86,13 @@ Note that `OPTUNA_DASHBOARD_DEBUG=1` makes the server will automatically restart
### Running tests, lint checks and formatters
#### Running typescript unit tests
#### Running unit tests for `tslib/`
```
$ make tstest
$ make tslib-test
```
#### Running Python unit tests
#### Running unit tests for `python_tests/`
```
$ pytest python_tests/
+5 -5
View File
@@ -18,17 +18,17 @@ vscode/assets/bundle.js: $(RUSTLIB_OUT) $(STANDALONE_SRC) tslib
$(DASHBOARD_TS_OUT): $(DASHBOARD_TS_SRC)
cd optuna_dashboard && npm install && npm run build:$(MODE)
.PHONY: tstest
tstest: tslib
cd tslib/react/test && python generate_assets.py && npm run test
cd tslib/storage/test && python generate_assets.py && npm run test
.PHONY: tslib
tslib:
cd tslib/types && npm i && npm run build
cd tslib/storage && npm i && npm run build
cd tslib/react && npm i && npm run build
.PHONY: tslib-test
tslib-test: tslib
cd tslib/react/test && python generate_assets.py && npm run test
cd tslib/storage/test && python generate_assets.py && npm run test
.PHONY: serve-browser-app
serve-browser-app: tslib $(RUSTLIB_OUT)
cd standalone_app && npm run watch