mirror of
https://github.com/wassname/scikit-image.git
synced 2026-06-27 18:25:32 +08:00
Update contributor's guide: all PRs must get two +1's by core team before merge
This commit is contained in:
+4
-1
@@ -77,6 +77,8 @@ For a more detailed discussion, read these :doc:`detailed documents
|
||||
Travis fails, you can find out why by clicking on the "failed" icon (red
|
||||
cross) and inspecting the build and test log.
|
||||
|
||||
* A pull request must be approved by two core team members before merging.
|
||||
|
||||
5. Document changes
|
||||
|
||||
If your change introduces any API modifications, please update
|
||||
@@ -127,7 +129,8 @@ Guidelines
|
||||
* All code should be documented, to the same
|
||||
`standard <https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt#docstring-standard>`_ as NumPy and SciPy.
|
||||
* For new functionality, always add an example to the gallery.
|
||||
* No changes are ever committed without review. Ask on the
|
||||
* No changes are ever committed without review and approval by two core
|
||||
team members. Ask on the
|
||||
`mailing list <http://groups.google.com/group/scikit-image>`_ if
|
||||
you get no response to your pull request.
|
||||
**Never merge your own pull request.**
|
||||
|
||||
Reference in New Issue
Block a user