Avoid compute metrics with 404 status code (#2587)

This commit is contained in:
Cristian Dean
2019-09-23 21:26:47 +00:00
committed by Wyatt Johnson
parent fe2d78f1f7
commit 37e39ff8c5
+7 -5
View File
@@ -20,12 +20,14 @@ export const metricsRecorder = ({
// Increment the request counter.
httpRequestsTotal.labels(`${res.statusCode}`, req.method).inc();
// Add the request duration.
httpRequestDurationMilliseconds
.labels(req.method, req.baseUrl + req.path)
.observe(responseTime);
// Only compute the request path when status code isn't 404 to avoid flood
if (res.statusCode !== 404) {
// Add the request duration.
httpRequestDurationMilliseconds
.labels(req.method, req.baseUrl + req.path)
.observe(responseTime);
}
});
next();
};
};